search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.1k stars 1.21k forks source link

[Digital Twins - Core] DigitalTwins Models - create, read, list, delete operations create models empty failing in nightly runs #22668

Closed v-jiaodi closed 4 months ago

v-jiaodi commented 2 years ago

Digital Twins - Core nightly test runs are failing with:

Error message: expected '"options.models" with value "" should…' to include 'Operation failed as models provided w…'

Stack trace: AssertionError: expected '"options.models" with value "" should…' to include 'Operation failed as models provided w…' at Context. (/mnt/vss/_work/1/s/sdk/digitaltwins/digital-twins-core/test/public/testModels.spec.ts:105:14) at runMicrotasks () at processTicksAndRejections (internal/process/task_queues.js:97:5) For more details check here:

johngallardo commented 2 years ago

Strangely, these tests are passing for some environments, but not others. They pass for ubuntu2004_14x_node, but fail for ubuntu2004_node_12x_max and ubuntu2004_node_12x_min. For the failure cases, I don't see evidence of the request failing in the service (the test is expecting a failure for this negative case).

johngallardo commented 2 years ago

@abhinav-ghai can you take a look?

johngallardo commented 2 years ago

@jeffyou543 seems related to https://github.com/Azure/azure-sdk-for-js/commit/f55930df9ef78743a14e349a1b35069b40ed26e1

jeffyou543 commented 2 years ago

The test failure is due to the use of azure/core-http dependency. But regardless the test should have no issue passing in each environment. The root cause is uncertain, but I want to check and see if anyone from the SDK team might have some insights on this?

@v-jiaodi @v-xuto ?

jeffyou543 commented 2 years ago

Issue has now been resolved by the following merged PR: https://github.com/Azure/azure-sdk-for-js/pull/22703

v-xuto commented 2 years ago

@jeffyou543 Thanks for your contribution to this issue. We did not reply to you in time as we are also still investigating.

github-actions[bot] commented 4 months ago

Hi @v-jiaodi, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.