Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.1k stars 1.21k forks source link

[Notification Hubs - src/models/notification.ts] Unable to notify Windows desktop apps #27695

Closed yuksato closed 1 year ago

yuksato commented 1 year ago

Describe the bug I have been using the Notification Hubs Node.js SDK to notify Windows desktop apps, but was not getting notifications. I changed the platform in the WindowsNotification type from wns to windows and the notification worked.

I checked the public Github source code (notification.ts) and found the following implementation.

notification.ts (270 line) Link : https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/notificationhubs/notification-hubs/src/models/notification.ts#L270

platform: "wns";

However, the public information lists it as windows. Link : https://learn.microsoft.com/ja-jp/rest/api/notificationhubs/send-wns-native-notification?view=rest-notificationhubs-2023-09-01#request-headers

ServiceBusNotification-Format : windows

We believe that the problem is that the SDK is set to wns, which is causing the issue of notifications not being sent to the Windows desktop application. Therefore, if the problem is on the SDK side, please fix it.

mpodwysocki commented 1 year ago

@yuksato fixed as per 1.0.3