Drops mcrypt - Githubissues

Azure / azure-sdk-for-php

Microsoft Azure SDK for PHP

http://azure.microsoft.com/en-us/develop/php/

Apache License 2.0

415 stars 276 forks source link

Closed captn3m0 closed 5 years ago

captn3m0 commented 5 years ago

This clears the way for PHP7.2 support.
Fixes https://github.com/Azure/azure-sdk-for-php/issues/918
Uses same code as https://github.com/paragonie/random_compat as a random_int polyfill (I'm running 7.2 and the upgrade is painful till phpdocumentor has a compatible release, so I didn't use the package instead) - Can take this up if really necessary.
mcrypt_encrypt changes are not tested as thoroughly as I'd like (help is appreciated)

msftclas commented 5 years ago

All CLA requirements met.

captn3m0 commented 5 years ago

Can this be reviewed please? Tests are passing.