[WAF - Reliability Review] - `avm/res/cache/redis`

[jtracey93]

Check for previous/existing GitHub issues

• [X] I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/cache/redis

(Optional) Module Name if not listed above

No response

(Optional) Module Version

No response

Description

Hello team,

The AVM core team are performing a review of all AVM modules to ensure they are aligned to the WAF reliability pillar by default, and in the future they will be checking against other WAF pillars also. This is a requirement we have before we can go v1.0.0 for any AVM module.

Links to AVM specs:

• https://azure.github.io/Azure-Verified-Modules/specs/shared/#id-sfr2---category-composition---waf-aligned
• https://azure.github.io/Azure-Verified-Modules/specs/shared/#id-sfr5---category-composition---availability-zones

Links to WAF Reliability, APRL & Product Docs recommendations used for analysis:

• https://learn.microsoft.com/azure/well-architected/reliability/checklist
• https://learn.microsoft.com/en-us/azure/azure-cache-for-redis/cache-how-to-zone-redundancy?toc=%2Fazure%2Freliability%2Ftoc.json&bc=%2Fazure%2Freliability%2Fbreadcrumb%2Ftoc.json
• https://learn.microsoft.com/en-us/azure/well-architected/service-guides/azure-cache-redis/reliability
• https://azure.github.io/Azure-Proactive-Resiliency-Library/services/database/redis-cache/
• https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.Redis.AvailabilityZone/#configure-with-bicep

Whilst reviewing this module the following issues have been found that are non-compliant with the AVM specs that need to be resolved in a new version release:

• Change the parameter of zoneRedundant to default to true
• Change the parameter of skuName to default to Premium
• Change the parameter of zones to default to [1,2,3]
  • May be able to remove the var for AZ logic https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/cache/redis/main.bicep#L108-L110
• Change the parameter of replicasPerMaster to default to 3

Please make these changes in a PR to the parameter defaults so a new minor version can be published.

Thanks

The AVM Core Team

(Optional) Correlation Id

No response

[microsoft-github-policy-service[bot]]

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

[!NOTE] This label was added as per ITA06.

[microsoft-github-policy-service[bot]]

[!NOTE] The "Type: Feature Request :heavy_plus_sign:" label was added as per ITA20.

[matebarabas]

@hundredacres, can you please take a look at this one? Thanks!

[hundredacres]

PR here: https://github.com/Azure/bicep-registry-modules/pull/1621

[microsoft-github-policy-service[bot]]

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

• To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
• To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!

[!NOTE] This message was posted as per ITA01BCP.