Azure / bicep-registry-modules

Bicep registry modules
MIT License
457 stars 302 forks source link

[AVM Module Issue]: ACA should allow pulling secrets from keyvault in addition to providing them directly #2721

Closed mosabami closed 1 month ago

mosabami commented 1 month ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/app/container-app

(Optional) Module Version

No response

Description

ACA bicep module allows user to pull secrets for ACA from keyvault as opposed to providing it as text in the Bicep module directly. This AVM only allows the latter. we need it to also allow the former. You can find here the base bicep resource allows it here: https://learn.microsoft.com/en-us/azure/templates/microsoft.app/containerapps?pivots=deployment-language-bicep#secret where the secret can be pulled from keyvault by providing the keyvault url

(Optional) Correlation Id

No response

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

avm-team-linter[bot] commented 1 month ago

@mosabami, thanks for submitting this issue for the avm/res/app/container-app module!

[!IMPORTANT] A member of the @Azure/avm-res-app-containerapp-module-owners-bicep or @Azure/avm-res-app-containerapp-module-contributors-bicep team will review it soon!

microsoft-github-policy-service[bot] commented 1 month ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
oZakari commented 1 month ago

As discussed over teams, will complete by early August at the latest.