Azure / caf-terraform-landingzones-accelerator

Starter project for Applications (level 4) Cloud Adoption Framework for Azure landing zones on Terraform
MIT License
205 stars 233 forks source link

Fix keyvault access policy config key and landingzone level #73

Closed heidecke closed 3 years ago

heidecke commented 3 years ago

64

PR Checklist


Description

The keyvault_access_policies_azuread_apps currently references the incorrect config key and the azure_devops template is configured at the incorrect level.

Does this introduce a breaking change

Testing

Running terraform plan should now produce no errors and the apply should now run without error.

heidecke commented 3 years ago

Apologies for the closed PR, my fancy git config working against me!

heidecke commented 3 years ago

@arnaudlh I'm not sure if the level change was on purpose to account for something else, but these two changes seemed to fix the error in the spirit of your most recent changes.

arnaudlh commented 3 years ago

thanks for the PR @heidecke