search

Azure / container-scan

A GitHub action to help you scan your docker image for vulnerabilities
MIT License
219 stars 42 forks source link

Support Trivy new JSON schema #106

Closed knqyf263 closed 2 years ago

knqyf263 commented 3 years ago

Fix https://github.com/Azure/container-scan/issues/104

ghost commented 3 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: knqyf263 sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

knqyf263 commented 3 years ago

I have signed CLA. GitHub ID was automatically filled, so I used it as is. Should it be my account name "knqyf263"? If so, could you tell me how to fix it? I didn't find any button to update the detail. image

knqyf263 commented 3 years ago 
$ curl -s https://api.github.com/user/2253692 | jq .login
"knqyf263"

My GitHub ID seems to be correct. I don't understand why CLA assistant is complaining about it.

JeffreyArt1 commented 3 years ago

Try the "recheck" button

knqyf263 commented 3 years ago

I did it many times.

ajinkya599 commented 3 years ago

Thanks @knqyf263 for the PR 🙌 . I am not sure what's going on with the CLA. Will check this internally. However, in the interest of time I have ported your fix to the release branch and updated the action.

kanika1894 commented 3 years ago

Hey @knqyf263, are you still facing the issue?

knqyf263 commented 3 years ago

Yes

ajinkya599 commented 3 years ago

Hey @knqyf263, We are working to resolve the CLA issue and it is unfortunately taking more time. Are you okay if I send out a separate PR and make these changes to main? We have more PRs to follow.

knqyf263 commented 3 years ago

Are you okay if I send out a separate PR and make these changes to main? We have more PRs to follow.

Sure. It would be great if my contribution is merged somehow, but please feel free to close the issue.

ajinkya599 commented 3 years ago

@knqyf263 I also wanted your contribution to be in but unfortunately this CLA issue is one-off and is taking longer. That's why I wanted to check with you if you are okay with me taking this separately.

knqyf263 commented 3 years ago

That's why I wanted to check with you if you are okay with me taking this separately.

I'm ok with that.

github-actions[bot] commented 3 years ago

This PR is idle because it has been open for 14 days with no activity.

ajinkya599 commented 2 years ago

Ported via the other PR: