Azure / deployment-environments

Sample infrastructure-as-code templates to get started with Azure Deployment Environments service.
MIT License
68 stars 223 forks source link

manifest.yaml differs from MS documentation #1

Closed tkimmm closed 2 years ago

tkimmm commented 2 years ago

https://learn.microsoft.com/en-gb/azure/deployment-environments/configure-catalog-item#add-a-new-catalog-item

Indicates that the manifest.yaml should have the structure:

name: WebApp
    version: 1.0.0
    description: Deploys an Azure Web App without a data store
    engine:
      type: ARM
      templatePath: azuredeploy.json

However the manifests in this sample project follow the structure:

name: FunctionApp
version: 1.0.0
summary: Azure Function App Environment
description: Deploys an Azure Function App, Storage Account, and Application Insights
runner: ARM
templatePath: azuredeploy.json

Can open a PR if required, just need confirmation which is correct

sagarlankala commented 2 years ago

Hi @tkimmm - Thank you for bringing it to our attention, the discrepancy has been resolved now! 👍