Azure / kafka-sink-azure-kusto

Kafka sink for Kusto
MIT License
48 stars 24 forks source link

add proxy support #95

Closed tanmaya-panda1 closed 1 year ago

tanmaya-panda1 commented 1 year ago

Pull Request Description

[Add a description of your pull request here]


Future Release Comment

[Add description of your change, to include in the next release] [Delete any or all irrelevant sections, e.g. if your change does not warrant a release comment at all]

Breaking Changes:

Features:

Fixes:

ohadbitt commented 1 year ago

Just a question - how did you test this? Also - maybe we should start linting our files with intellij ctrl+alt+L

ag-ramachandran commented 1 year ago

@tanmaya-panda1 can you reply to the comments above

ag-ramachandran commented 1 year ago

@tanmaya-panda1 , @ohadbitt working on tests. Will push the code in 1 hour or so

ohadbitt commented 1 year ago

files

I think manual test is better but it might be cumbersome ..

tanmaya-panda1 commented 1 year ago

Just a question - how did you test this? Also - maybe we should start linting our files with intellij ctrl+alt+L

Hi Ohad, I tested it by configuring the system level proxy for all outbound connections. The proxy I used was free proxy from internet. I am yet to test for https connections. I will update here once done.

ag-ramachandran commented 1 year ago

@tanmaya-panda1 @ohadbitt In the E2E test for the Avro ingest scenario, I sent it through an embedded proxy. There is some code that needed changing that I have done. Pl. provide feedback. We can manually test through a proxy tomorrow as well.

image