Azure / mlops-v2

Azure MLOps (v2) solution accelerators. Enterprise ready templates to deploy your machine learning models on the Azure Platform.
https://learn.microsoft.com/en-us/azure/machine-learning/concept-model-management-and-deployment
MIT License
502 stars 248 forks source link

Github Action Deprecated #92

Open jplummer01 opened 1 year ago

jplummer01 commented 1 year ago

Describe the bug or the issue that you are facing

image

Steps/Code to Reproduce

run the tf-gha-deploy-infra.yml github action

Expected Output

use of deprecated github feature

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Versions

latest MLOps-V2 Accelerator

Which platform are you using for deploying your infrastrucutre?

GitHub Actions (GitHub)

If you mentioned Others, please mention which platformm are you using?

No response

What are you using for deploying your infrastrucutre?

Terraform

Are you using Azure ML CLI v2 or Azure ML Python SDK v2

Azure ML CLI v2

Describe the example that you are trying to run?

following latest deployment guide

setuc commented 1 year ago

@setuc is reviewing

sdonohoo commented 1 year ago

I investigated this. The deprecated set-output calls are not explicitly in the MLOps SA code. They are in the javascript toolkit library used by the read_yaml action. This deprecation warning was recently reported for the toolkit itself (https://github.com/actions/toolkit/issues/1336) though no update is available yet. Will monitor updates to the toolkit to mitigate the deprecation as well as investigate workarounds or new approach to read_yaml implementation in MLOps.

djdean commented 1 year ago

This is apparently fixed in @actions/core v1.10.0, updated the NPM packages to the latest versions and created a PR. Unfortunately it looks like the warning will still be there but there is a fix in the actual code.