Azure / pcs-remote-monitoring-webui

Azure IoT PCS Remote Monitoring Web UI
MIT License
54 stars 72 forks source link

Device delete is broken for newly added devices in feature/packagePage #1106

Closed mechaffin closed 6 years ago

mechaffin commented 6 years ago

Type of issue

Description

Yellow screen of death when deleting a device with the glimmer icon (newly created) when in the feature/packagePage branch. This may have been introduced with the glimmer icon in this branch... as the master branch works properly.

Steps to reproduce

  1. Create a new device
  2. Notice the glimmer icon next to the name of the new device in the grid
  3. DO NOT REFRESH THE PAGE
  4. Check the box next to that new device
  5. Delete that new device

Expected behavior

Device is deleted from the server and within the grid.

Current behavior <!-- The actual behavior observed --

Device is deleted from the server, but the UI page goes blank and comes up with the yellow screen of death.

Known workarounds

Refresh the page. Things will appear correctly deleted. Items that are not newly created (i.e only exist in the redux store because we put them there and don't have the glimmer icon) will be deletable with no error.

Possible solution

Something appears to be missing (or perhaps added) in the data added to the redux store for newly created items which causes the error.

Context and Environment

Screenshot

image

mechaffin commented 6 years ago

FIxed with #1114