search

Azure / terraform-azurerm-aks

Terraform Module for deploying an AKS cluster
MIT License
361 stars 468 forks source link

Make the Azure Key Vault public because private Key Vault requires preview API #599

Closed zioproto closed 3 weeks ago

zioproto commented 3 weeks ago

Running Microsoft Terraform module AKS end to end tests I get this new error message I have never seen before from the ARM API:

https://github.com/Azure/terraform-azurerm-aks/actions/runs/11665268834/job/32477571013?pr=598#step:3:6605

HTTP 400 "Vnet integration should be enabled when KeyVault network access is Private."

I believe this is the root cause: https://learn.microsoft.com/en-us/azure/aks/use-kms-etcd-encryption#prerequisites ( See yellow warning box)

However Vnet Integration is still preview as far as I know. Terraform provider azurerm V4 will not support preview features. https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/guides/4.0-upgrade-guide#aks-migration-to-stable-api

This is a workaround to get the CI running again. This PR needs to be reverted once AKS API Vnet Integration goes GA

zioproto commented 3 weeks ago

The end to end test is now failing on the upgrade step. It cannot pass the upgrade test because the current main branch cannot pass the end to end test.