search

Azure / terraform-azurerm-avm-res-web-site

MIT License
17 stars 10 forks source link

[AVM Module Issue]: App service logs are always disabled for webapps #82

Closed thenewnano closed 5 months ago

thenewnano commented 5 months ago

Check for previous/existing GitHub issues

Issue Type?

Bug

(Optional) Module Version

0.6.3

(Optional) Correlation Id

No response

Description

I see that the part of the code passing on app service logs settings are commented out in main.webapps:51:55 this is strange as the feature is supported in the web-app and we are using it for debugging. Any reason why this is set always to off and if you could uncomment it ?

donovm4 commented 5 months ago

Hi @thenewnano - I wouldn't say this is set off by default per the module. Please review the azurerm provider documentation for the web apps versus the function apps.

azurerm_linux_function_app and azurerm_windows_function_app accept site_config > app_service_logs via module documentation

azurerm_linux_web_app and azurerm_windows_wep_app accept logs > application_logs via module documentation

As for why it is commented out, I haven't cleaned up some of the work/comments from the initial development - please forgive me for causing any confusion.

Please let me know how I can further assist.

thenewnano commented 5 months ago

OK fair enough, although it is available in azure portal for both web app and function app

thenewnano commented 5 months ago

we can close this