Azure / terraform-azurerm-naming

MIT License
213 stars 107 forks source link

route and route-table names mixed up #104

Open davidkarlsen opened 1 year ago

davidkarlsen commented 1 year ago

The naming postfixes for route vs route-table seem to be mixed up https://github.com/Azure/terraform-azurerm-naming/blob/master/main.tf#L1863 vs https://github.com/Azure/terraform-azurerm-naming/blob/master/main.tf#L1873

AndyAtTib commented 7 months ago

Cloud adoption framework ref:

https://github.com/MicrosoftDocs/cloud-adoption-framework/blob/9c79a463605a576c46f0dd1ba125d5b09585c58e/docs/ready/azure-best-practices/resource-abbreviations.md?plain=1#L241

| Route table | `Microsoft.Network/routeTables` | `rt` |

Bug source:

https://github.com/Azure/terraform-azurerm-naming/blob/528b026c3465f720155f1b16f2589300de638e34/resourceDefinition.json#L1663-L1684

The naming postfixes for route vs route-table seem to be mixed up https://github.com/Azure/terraform-azurerm-naming/blob/master/main.tf#L1863 vs https://github.com/Azure/terraform-azurerm-naming/blob/master/main.tf#L1873

Those links apply to v0.3.0:

The relevant lines are:

https://github.com/Azure/terraform-azurerm-naming/blob/528b026c3465f720155f1b16f2589300de638e34/main.tf#L1859-L1863

https://github.com/Azure/terraform-azurerm-naming/blob/528b026c3465f720155f1b16f2589300de638e34/main.tf#L1869-L1873