search

B-Interactive / cloudflare-stream-wordpress

A fork of the official Cloudflare Stream plugin for WordPress.
GNU General Public License v2.0
16 stars 3 forks source link

Upload button is missing #9

Closed davidmpurdy closed 2 years ago

davidmpurdy commented 2 years ago

Looks like I broke the upload button didn't come in with my block fix. Probably because I based my solution on previous work that didn't incorporate the API token improvement, and the block uses API credentials to directly upload files via tus.

Working on a fix to send the token/zone instead of the key/account/email to the block script and change the base URL appropriately within the block.

davidmpurdy commented 2 years ago

OK, I think it's working, but there's an error after upload that I think has to do with the block still using the legacy player. Unless there's an objection, I think I'll just roll it into a PR to fix/update the block (#6 ) so I can test it all together instead of little piecemeal updates, each with something broken in them. While we're cleaning house and updating, bigger PRs that just fix problems feels like the approach to me.

B-Interactive commented 2 years ago

Hey no worries @davidmpurdy. Just give me a heads up if you're planning any big changes to class-cloudflare-stream-api.php, or class-cloudflare-stream-settings.php, as that's where my attention has mostly been.