Cinnamon and menu button/icon

[ghost]

As suggested in the pling.com blog, I am posting these here too... -This first issue I initially thought was something in the themes, but later determined that it occured independently of the selected theme (yours or otherwise) and is almost certainly metacity. I only mention it here in the hope that you have run across it. Some time in between upgrading from Mint 19.1 to 19.2 I lost the application icon that appears in the upper-left corner of the windows where the window-menu is activated. (System Settings|Windows|Titlebar tab|Buttons group|'Left side title bar buttons'|first-drop-down="Menu") After doing some testing in two virtual machines running (linux Mint Cinnamon) 19.1 and 19.2 respectively, I was able to determine that this issue is with a change in Linux Mint (Cinnamon) 19.2, because all 3 versions display the application icon in 19.1 and do not display it in 19.2. (Mint themes display an arrow in 19.1 and no arrow in 19.2). As I said, not an issue with the themes, but any insight appreciated...

Update: I ran across a link somewhere that I unfortunately don't have here but it was indicated (hearesay) that this was a change in Cinnamon for 19.2 to no longer handle the metacity tag "icon". It sure seems to be the case. I resolved this by noting that MintX and MintY displayed an arrow, and I borrowed from MintY and made lighter/darker versions to handle the focused/unfocused/highlighted events. Then I had to edit a bunch for "frame_style" tags of different "geometry=..." configurations.

I can make the modified theme files available to you upon request.

[Elbullazul]

can you submit your changes as a pull request?

[ghost]

OK, will take a shot at it (PR)... ...Update: OK, now that I've done a few simple PRs, I can take on this one, which will involve a number of .PNG files added to the metacity-1 folder of every theme, and corresponding changes to certain frame_geometry tags (normal/maximized, focused/unfocused) in the metacity-theme-3.xml of each theme.

[ghost]

Another note as I start working on this: as you'll note from the two tiny screenshots above, I added more than just the menu arrow to my copy, but this issue (#12) will be limited to that button / icon, and I'm going to introduce a separate issue for the additional button / icons (sticky, shade) (#20).

[ghost]

Note also that I'm basing each PR on master, so changes from the other PRs will not be reflected in each PR. As two of the PRs affect one file (metacity-theme-3.xml) and two others affect a second file (cinnamon.css), it is important to note that changes in a given PR do not account for the others. I supposed normally I would not be doing 4 in quick succession and would be re-basing (I think that is the term I read) each PR, but that is not the case here.

[Elbullazul]

@ssepan2 no problem. conflicts shouldn't appear unless you edited the same line(s) in multiple commits

for the buttons, I'm still planning on rebasing metacity themes on a more modern base (current causes issues with firefox), so maybe it won't make it into master. Submit it anyways, because I'm unsure when I'll have time to make a new version

[ghost]

Cool. Nope, different lines. OK, I'll submit it just in case it can be used. Thx

[Elbullazul]

139de747f17ba5b4bb196d1b6eb6f2bd3ab90793 and 26843c4eae95908ba78954e627508e155129e2e9 fixes this