kezboard inout x search bug (very annoying)

[GlassesCatandsteve]

Describe the bug

When doing the following things 1 : typing a value in the enjoyment rating (dont know if this applies to the other textboxes) with your keyboard 2 : playing one of the searched levels

basically , in your code you forgot to implement a function that closes the gddl filter menu / exits zou out of the textbox , so when you play a level(which you searched for with the gddl filter) after typing in a value with your keyboard (as described above) all keyboard inputs still get sent to the textbox , so while playing the level , if you press eg. the spacebar to jump , it types a space in the textbox of the filter menu (as described above) . should be an easy fix (idk if it is , i am a programmer but dont know c++)

To Reproduce Steps to reproduce the behavior:

1. go to the online search tab
2. click on the red question mark button
3. type any value into the enjoyment textbox with your keyboard
4. search up a level with that value via your filter
5. play the level
6. try to make a keyboard input
7. see error (after leaving the level gd crashes alot of the times)

2024-03-02_12-25-35.log 2024-03-02_12-27-41.log

Additional context none I checked that I have the latest version of this mod Yes

please fix this ASAP :)

[B1rtek]

Interesting, I can see why it could happen but I can't replicate the crash. I'll take care of it anyway because you probably shouldn't be able to input stuff into a textbox that you can't see

[GlassesCatandsteve]

yea , ty , you cant replicate the crash or the issue

B1rtek @.***> schrieb am Mo., 4. März 2024, 13:02:

Interesting, I can see why it could happen but I can't replicate the crash. I'll take care of it anyway because you probably shouldn't be able to input stuff into a textbox that you can't see

— Reply to this email directly, view it on GitHub https://github.com/B1rtek/Geode-GDDLIntegration/issues/27#issuecomment-1976427688, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS4YHMM3G5N62LOBXDQFGATYWRPGZAVCNFSM6AAAAABEDBAHDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZWGQZDONRYHA . You are receiving this because you authored the thread.Message ID: @.***>

[B1rtek]

The crash, I am able to type into the search textboxes though, so I guess I'm just lucky

Another reason why it might crash us because of garbage input being sent to stoi()/stof() which i think is the main culprit here from looking at the logs, I'll take care of that too

[B1rtek]

There's a high chance that this is fixed by the new patch, stoi() shouldn't crash the game anymore and you get automatically clicked off from all text input fields, but I can't know that for sure since I never managed to replicate your crashes

[GlassesCatandsteve]

weird , anyways thank you , the main issue was the input anyways

B1rtek @.***> schrieb am Fr., 8. März 2024, 21:01:

There's a high chance that this is fixed by the new patch, stoi() shouldn't crash the game anymore and you get automatically clicked off from all text input fields, but I can't know that for sure since I never managed to replicate your crashes

— Reply to this email directly, view it on GitHub https://github.com/B1rtek/Geode-GDDLIntegration/issues/27#issuecomment-1986340120, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS4YHMIZZOR3R36MZNBMLDTYXIKIHAVCNFSM6AAAAABEDBAHDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWGM2DAMJSGA . You are receiving this because you authored the thread.Message ID: @.***>

[B1rtek]

https://github.com/B1rtek/Geode-GDDLIntegration/releases/download/v1.1.3/b1rtek.gddlintegration.geode here's a link to the newest release, you can also just wait for it to be uploaded to the geode mod index