B3none / cs2-retakes

CS2 implementation of retakes. Based on the version for CS:GO by Splewis.
GNU General Public License v3.0
192 stars 38 forks source link

Separate hint and chat bombsite announce. #69

Closed IT-CHI closed 9 months ago

IT-CHI commented 9 months ago

separate please hint & chat message because it will not get drawn in hint and breakdown since hints has html formatting config:"retakes.bombsite.announcement": "Retake [GREEN]{0}[SILVER]: [RED]{1} Ts[SILVER] vs [BLUE]{2} CTs" result: obrazek obrazek

B3none commented 9 months ago

Ah yes, I will need to update the translation later to handle that

B3none commented 9 months ago

Had a quick look into this and it's not initially as easy as "just implementing a new translation", the translation wrapper will need to be updated to handle HTML tags too for the supported colours. I have thought of a solution to implement it which would be to switch [GREEN] for <font color="green"> and keep a count of the total replaced then prepend the translation string with </font> for the total number of replacements. This might want some regex magic to do this but it's going to take longer than 5 minutes to implement 👍

Here's a potential (albeit hacky) solution: https://github.com/B3none/cs2-retakes/actions/runs/7779457259/artifacts/1219214194

If you can test it works as expected I'll make the release 💪

B3none commented 9 months ago

This issue is fixed in the 1.3.26 release 👍