BBVAEngineering / ember-cli-workbox

Offline caching as a progressive enhancement using service workers
MIT License
20 stars 10 forks source link

It's not possible to override default settings #108

Closed oscarni closed 2 years ago

oscarni commented 3 years ago

Looks like workbox options are set in stone. These lines: https://github.com/BBVAEngineering/ember-cli-workbox/blob/master/index.js#L19-L26 probably needs to be updated to :

workboxOptions = Object.assign({
  swDest: 'sw.js',
  globDirectory: './',
  globPatterns: ['**/*.{json,css,js,png,svg,eot,ttf,woff,jpg,gif,ico,xml,html,txt}'],
  skipWaiting: false,
  clientsClaim: false,
  cacheId: projectName
}, workboxOptions);

I could create a PR, but lines https://github.com/BBVAEngineering/ember-cli-workbox/blob/master/index.js#L37-L43 probably also needs an update, but I'm not sure what options and appOptions are.

adrigzr commented 2 years ago

:tada: This issue has been resolved in version 3.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: