search

BCDA-APS / bdp_controls

APS-U Beam line Data Pipelines - experiment controls with EPICS and Bluesky
Other
0 stars 1 forks source link

revert FilePath override #36

Closed prjemian closed 2 years ago

prjemian commented 2 years ago

Per https://github.com/bluesky/ophyd/pull/1038#issuecomment-1101727312, remove this local override: https://github.com/BCDA-APS/bdp_controls/blob/cf8586bcca4320685d38402aa3a3eec65021db6d/qserver/instrument/devices/area_detector.py#L64-L94

and test that detector staging and data acquisition proceed without reported timeout due to writing the bdpad:Hdf1:FilePath PV.

prjemian commented 2 years ago

Ran tests using existing game_client and did not encounter the TimeoutError as reported. Will accept this change and report upstream.

Summary

It is important to document when an incident occurs.