search

BCStudentSoftwareDevTeam / celts

Web app to support the CELTS program at Berea College
BSD 3-Clause "New" or "Revised" License
1 stars 8 forks source link

Toggle fullscreen #1256

Open MImran2002 opened 2 days ago

MImran2002 commented 2 days ago

Hi Brain I have edited to button to make it look decent and good UI design and I have changed the Boolean parameter to make the toggle works

MImran2002 commented 1 day ago

this is the issue : https://github.com/BCStudentSoftwareDevTeam/celts/issues/1122

Ndiayem14 commented 1 day ago

We reviewed this pull request, and it looks great. They did a good job, making it work as well as it should be. Good job guys.

ali-ramazani commented 1 day ago

We checked the website after the implemented fixes, and the issues were resolved. We also checked the code, and everything seemed fine. However, one small change we suggest is changing variable types from 'var' to 'let' to stick to modern JavaScript conventions and avoid potential errors.

github-actions[bot] commented 1 day ago

View Code Coverage