BCcampus / pressbooks-openstax-import

[UNMAINTAINED] Pressbooks Plugin for OpenStax Textbook Import
GNU General Public License v3.0
5 stars 0 forks source link

Notification improvements on import screen #68

Closed greatislander closed 6 years ago

greatislander commented 6 years ago

Description

When the OpenStax/CNX format is selected, additional notifications are shown. However, they are not positioned within the standard WordPress page content wrapper, which has accessibility implications as they are outside of the ARIA-defined main content (and is non-standard behaviour):

screen shot 2018-06-28 at 3 34 58 pm

Expected behaviour

Messages should be inserted within #wpbody-content #wrap after the initial h1, which is where WordPress puts its admin notices.

Actual behaviour

They are inserted before #wpbody-content.

Steps to reproduce the problem

Navigate to import, select cnx.org.

System Information

bdolor commented 6 years ago

resolved via https://github.com/BCcampus/pressbooks-openstax-import/commit/f7b17f69cd87255ad4db4060d3c417771c83b9ea