BCcampus / pressbooks-openstax-import

[UNMAINTAINED] Pressbooks Plugin for OpenStax Textbook Import
GNU General Public License v3.0
5 stars 0 forks source link

Footnotes: Note text appears at the bottom of the page with no indication of where it is referencing #83

Closed josieg closed 6 years ago

josieg commented 6 years ago

Description

Footnotes are not importing properly. The note reference mark (aka the superscript number that marks the spot of a citation in a paragraph) is stripped out during import and a space is inserted where it should be. The note text (e.g the actual citation statement that the note reference mark is pointing to) appears at the bottom of the page in an ordered list above the glossary terms.

Expected behaviour

I expect that when importing an OpenStax book into Pressbooks, end notes in the CNX platform would be pulled into the Pressbooks footnote tool. This would involve putting the note text from the CNX platform into [footnote]x[/footnote] tags where the note reference mark was.

This would insure that:

Actual behaviour

Here a paragraph with a note reference mark in the CNX platform. cnxfootnote Here is the same paragraph after it has been imported into Pressbooks: cnxpbfootnote Note the following:

Here is what the same paragraph looks like in the html editor in Pressbooks: cnxpbhtmlfootnote

And here is what the note text looks like once it's been imported into Pressbooks: cnxpbendnote

Steps to reproduce the problem

  1. Import a book into Pressbooks that has footnotes. E.g., Business Ethics
  2. Look at the places where footnotes should be in the Pressbooks version. (Here is a PB copy of Business Ethics)
bdolor commented 6 years ago

resolved via https://github.com/BCcampus/pressbooks-openstax-import/commit/afec817cd9307a80e04444b5a6e35336f147ee89

josieg commented 6 years ago

This fix also looks good.