BG-Software-LLC / SuperiorSkyblock2

Optimized, feature packed Skyblock core.
https://bg-software.com/superiorskyblock/
GNU General Public License v3.0
167 stars 144 forks source link

many spawner heads do now show up in ``/is blocks`` #2260

Open homerek111 opened 6 days ago

homerek111 commented 6 days ago

Minecraft's Version

This server is running Paper version 1.21.1-100-master@20ec622 (2024-09-26T23:53:46Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)

Plugin's Version

2024.3-b339

Describe the bug

many types of spawner heads do not show up in /is blocks - I have them all defined in worth.yml and heads.yml but some work / some does not... These types of spawners are being properly counted into island value but it's heads are not visible in /is blocks

Example of properly working heads:

Examples of not working heads:

My files: worth.yml: https://pastebin.com/taz6guCS heads.yml: https://pastebin.com/MCQeF2N9

To Reproduce

-

Additional Information

No response

OmerBenGera commented 5 days ago

Check out latest dev build, let me know if it is fixed

homerek111 commented 5 days ago

Check out latest dev build, let me know if it is fixed

@OmerBenGera hmmm it is not fixed - still the same situation

OmerBenGera commented 4 days ago

Check out latest dev build, let me know if it is fixed

@OmerBenGera hmmm it is not fixed - still the same situation

It works fine for me Make sure you have your heads.yml file updated with all the mobs and their textures.

homerek111 commented 4 days ago

Check out latest dev build, let me know if it is fixed

@OmerBenGera hmmm it is not fixed - still the same situation

It works fine for me Make sure you have your heads.yml file updated with all the mobs and their textures.

it still happens - here are my full files:

EXAMPLE:

here are 3 spawners (1x chicken + 2x parrot) 2024-10-19_14 41 27

in /is blocks there are 3 spawners + 1x chicken head but 2x parrot head is missing obraz

OmerBenGera commented 4 days ago

The 3 spawners are probably the global spawner key. You probably dont see the parrot spawner because it was not tracked

homerek111 commented 4 days ago

The 3 spawners are probably the global spawner key. You probably dont see the parrot spawner because it was not tracked

There are mob types that always show heads and some other (parrot for example) that never works properly. When you place ONLY parrot spawner - it’s head is not displaying as well.

OmerBenGera commented 3 days ago

The 3 spawners are probably the global spawner key. You probably dont see the parrot spawner because it was not tracked

There are mob types that always show heads and some other (parrot for example) that never works properly. When you place ONLY parrot spawner - it’s head is not displaying as well.

It means the block is not tracked probably. Run /is admin debug add_counts and see what is printed to console when you place a parrot spawner.

homerek111 commented 3 days ago

The 3 spawners are probably the global spawner key. You probably dont see the parrot spawner because it was not tracked

There are mob types that always show heads and some other (parrot for example) that never works properly. When you place ONLY parrot spawner - it’s head is not displaying as well.

It means the block is not tracked probably. Run /is admin debug add_counts and see what is printed to console when you place a parrot spawner.

@OmerBenGera there was no add_counts filter - I used block_count_increase instead

[00:22:32 INFO]: _homerek issued server command: /is recalc
[00:22:32 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {STONE} {51}
[00:22:32 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {LAVA_CAULDRON} {1}
[00:22:32 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {POTTED_TORCHFLOWER} {1}
[00:22:32 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {SPAWNER:COW} {3}
[00:22:32 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts Limit Key {SPAWNER}
[00:22:32 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {SPAWNER:CHICKEN} {1}
[00:22:32 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts Limit Key {SPAWNER}
[00:22:32 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {SPAWNER:PARROT} {3}
[00:22:32 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {COBBLESTONE} {18}
[00:22:32 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {POTTED_CORNFLOWER} {1}

in console debug there are 3x parrot spawner + 3x cow spawner + 1x chicken spawner but in /is blocks there are no parrot heads

obraz

homerek111 commented 3 days ago

hmmm what i found out is that properly working heads have this additional console log under it's spawner info: [00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts Limit Key {SPAWNER}

[00:25:18 INFO]: _homerek issued server command: /is recalc
[00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {STONE} {51}
[00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {LAVA_CAULDRON} {1}
[00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {POTTED_TORCHFLOWER} {1}
[00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {SPAWNER:COW} {3}
[00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts Limit Key {SPAWNER}
[00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {SPAWNER:SLIME} {1}
[00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts Limit Key {SPAWNER}
[00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {SPAWNER:CHICKEN} {1}
[00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts Limit Key {SPAWNER}
[00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {SPAWNER:ALLAY} {1}
[00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {SPAWNER:PARROT} {3}
[00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {COBBLESTONE} {18}
[00:25:18 INFO]: [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts {_homerek} {POTTED_CORNFLOWER} {1}

slime / cow / chicken heads work good = they all have [SuperiorSkyblock2] DefaultIslandBlocksTrackerAlgorithm::addCounts Limit Key {SPAWNER} debug info

parrot / allay heads do not work = they dont have this console log line obraz

maybe it's somehow connected?