BG-Software-LLC / WildChests

Sell chests, auto crafters, storage units, larger chests and more in one plugin!
https://bg-software.com/wildchests/
GNU General Public License v3.0
38 stars 23 forks source link

Notifier needs a check #165

Closed Superalex0102 closed 1 year ago

Superalex0102 commented 1 year ago

Minecraft's Version

1.18.2 paper

Plugin's Version

b81

Describe the bug

image

So the notifier feature has 2 major bugs currently.

1) The amount that it says is always a lower value than the actual one (maybe because of ShopGUI's modifiers?) 2) The same item is somehow written multiple times as "x64", in this case it's written twice.

Can you please look into these?

To Reproduce

-

Additional Information

No response

OmerBenGera commented 1 year ago
  1. The amount being displayed is identical to the amount deposited by WildChests. Therefore, if SGP or any other plugin deposited additional money, it will not be seen here.
  2. The same item is displayed, which makes me believe the items were not identical. I think it happens if you sell two items with different name, for example. Can you confirm/deny it?
Superalex0102 commented 1 year ago
  1. I don't get any money from anywhere else I even tested this on my test server
  2. The item is blank with no names at all and it does this with every spawner type I have tested so far
OmerBenGera commented 1 year ago

About the second bug, open a new issue regarding this, and we'll focus on the first bug in this report. Let me know how to replicate the issue - what items to put in the sell chest, etc. Make sure you use default config files for all the plugins you use, and even better - use only WildChests for this test.

Superalex0102 commented 1 year ago

I will make an issue for the second bug. On this video both of the bugs occured. I used default config of WildStacker and WildChests, the only changes I made is shown on the video.

On my public server I use a 5 minute notifier interval and the difference is huge, but even with a 1 minute notifier there is a noticeable difference.

https://youtu.be/-vK0d5P_RQw

OmerBenGera commented 1 year ago

Sell items individually by putting them in the sell chest. Let me know if you can replicate the issue.

Superalex0102 commented 1 year ago

image Yep still occurs, the difference is huge.

OmerBenGera commented 1 year ago

Check out latest dev build, let me know if it's better.

Superalex0102 commented 1 year ago

Works, ty