search

BG-Software-LLC / WildChests

Sell chests, auto crafters, storage units, larger chests and more in one plugin!
https://bg-software.com/wildchests/
GNU General Public License v3.0
38 stars 23 forks source link

WildChests causing lag #189

Closed Superalex0102 closed 1 year ago

Superalex0102 commented 1 year ago

Minecraft's Version

Paper 1.18.2

Plugin's Version

WildChests-2023.1-b5

Describe the bug

https://spark.lucko.me/wktuONJTI2

There are random tps drops from 20 to 16 every few seconds, I don't have too much suction chests that should cause this kind of problem.

To Reproduce

Config: https://pastebin.com/uPaEZK9e

Additional Information

No response

OmerBenGera commented 1 year ago

Check out latest dev build, let me know if it is better.

Superalex0102 commented 1 year ago

Check out latest dev build, let me know if it is better.

https://spark.lucko.me/aEWshKemPH did not fix it

Superalex0102 commented 1 year ago

any updates on this?

Check out latest dev build, let me know if it is better.

OmerBenGera commented 1 year ago

Check out latest dev build, let me know if it is better

Superalex0102 commented 1 year ago

Check out latest dev build, let me know if it is better

Now the chest doesn't pick up the items

OmerBenGera commented 1 year ago

I reverted the changes, sorry about that. I'd like if you can take one more spark profiler using the latest dev build, thanks.

Superalex0102 commented 1 year ago

https://spark.lucko.me/HlZVeKIYLQ

Superalex0102 commented 1 year ago

Can we please fix this? My server is lagging because of this issue for nearly a month now. I have provided all the details you have requested.

I reverted the changes, sorry about that. I'd like if you can take one more spark profiler using the latest dev build, thanks.

HamtaBot commented 1 year ago

Can we please fix this? My server is lagging because of this issue for nearly a month now. I have provided all the details you have requested.

I reverted the changes, sorry about that. I'd like if you can take one more spark profiler using the latest dev build, thanks.

if you want for now the issue doesnt occur on WildChests-2022.7-b84 I know its outdated but thats a temp fix for lags

Superalex0102 commented 1 year ago

@HamtaBot The problem is that all the previous builds were removed from jenkins, where can I download it now or should I just compile with that version from github?

HamtaBot commented 1 year ago

If you add me on discord I can give you the build my discord is hamtabot

HamtaBot commented 1 year ago

WildChests-2022.7-b84.zip

HamtaBot commented 1 year ago

hello can we get an update on this , my server is stuck on the update process since i cannot updata wild chest without having crash every 5 mins

HamtaBot commented 1 year ago

@OmerBenGera

OmerBenGera commented 1 year ago

@HamtaBot There's no need to keep tagging me. I currently have no solution and I don't have a fix for it atm.

HamtaBot commented 1 year ago

oh yeah excuse me im just gonna stick with the bug and keep a server with 100 concurent players crashing 15 times a day my bad

HamtaBot commented 1 year ago

lets hope you find a fix, have a good luck and great day

OmerBenGera commented 1 year ago

@HamtaBot Check out latest dev build, let me know if it is better.

HamtaBot commented 1 year ago

@HamtaBot Check out latest dev build, let me know if it is better.

so it seems to be a bit better now it start crashing later but still crash when a lot of mobs are dead at the same times on chests

HamtaBot commented 1 year ago

here is the report https://spark.lucko.me/o6Eawj4RYu

RisDN commented 1 year ago

I can confirm this. Im having the same tps issue since i updated to this version of WildChests.

HamtaBot commented 1 year ago

I can confirm this. Im having the same tps issue since i updated to this version of WildChests.

yeah 2022 builds was what i was using with no issue but unfrotunatly they doest works anymore on 1.20.1 WildChests-2022.7-b84 doesnt have the issue if that can help

OmerBenGera commented 1 year ago

@HamtaBot I think I found what the issue was. When having stacked items that are larger than 64 items, the plugin divided them into individual items, then added them all one by one. I changed it to treat the item as one item now, and it should be much better (Similar to the mentioned build above). Let me know if it works.

HamtaBot commented 1 year ago

image MAn i wanna suck something really hard right now THANK YOUUU my life saver

OmerBenGera commented 1 year ago

Finally, I am so glad it works now :) We can look at the bright side at least, many more optimizations were added as well as fixing the original bug. Do you mind taking a spark profiler as well?

HamtaBot commented 1 year ago

sure https://spark.lucko.me/g0I8aoWoNq

Finally, I am so glad it works now :) We can look at the bright side at least, many more optimizations were added as well as fixing the original bug. Do you mind taking a spark profiler as well?

HamtaBot commented 1 year ago

now the only thing taking tick that could maybe be optimized is the shopguiplus hook

OmerBenGera commented 1 year ago

now the only thing taking tick that could maybe be optimized is the shopguiplus hook

As you can see, this is ShopGUIPlus's code, and nothing can really be done regarding this on my side. I am closing this for now :)

HamtaBot commented 1 year ago

yeah im gonna ask brcdev thank you so much