BG-Software-LLC / WildChests

Sell chests, auto crafters, storage units, larger chests and more in one plugin!
https://bg-software.com/wildchests/
GNU General Public License v3.0
38 stars 23 forks source link

[ShopGUIPlus] [No Solution] Wildchest still takes a lot of server ticks causing some lags still #204

Closed HamtaBot closed 6 months ago

HamtaBot commented 1 year ago

Minecraft's Version

1.20.1 purpur

Plugin's Version

latest dev build

Describe the bug

after all the update made wildchests seems to still take some ticks that can be fixed i guess https://spark.lucko.me/Szf2pUyLhY

To Reproduce

just instal the plugin and make mobs spawn and die on it

Additional Information

No response

HamtaBot commented 1 year ago

after talking with shopguiplus support for 4 hours they said they have nothing to do with its on your end

HamtaBot commented 1 year ago

we ended up with that image

HamtaBot commented 1 year ago

it seems to really be related to wildchest since when i disable the plugin shopguiplus use 0.03% so going from 14% to 0.03% it doesnt happen on older builds of wildchests

OmerBenGera commented 1 year ago

it seems to really be related to wildchest since when i disable the plugin shopguiplus use 0.03% so going from 14% to 0.03% it doesnt happen on older builds of wildchests

If you removed SGP and it went from 14% to 0.03%, then it is definitely an issue of SGP. In older versions of WildChests I used my own version for detecting prices out of SGP due to their laggy code. However, this caused issues with price modifiers and such. I already contacted their author and he confirmed the issue.

HamtaBot commented 1 year ago

no you didnt undstand , when i removed wildchest shopgui plus was using 0.03, so what i am supposed to do , i contacted their support and they said its you

it seems to really be related to wildchest since when i disable the plugin shopguiplus use 0.03% so going from 14% to 0.03% it doesnt happen on older builds of wildchests

If you removed SGP and it went from 14% to 0.03%, then it is definitely an issue of SGP. In older versions of WildChests I used my own version for detecting prices out of SGP due to their laggy code. However, this caused issues with price modifiers and such. I already contacted their author and he confirmed the issue.

OmerBenGera commented 1 year ago

no you didnt undstand , when i removed wildchest shopgui plus was using 0.03, so what i am supposed to do , i contacted their support and they said its you

it seems to really be related to wildchest since when i disable the plugin shopguiplus use 0.03% so going from 14% to 0.03% it doesnt happen on older builds of wildchests

If you removed SGP and it went from 14% to 0.03%, then it is definitely an issue of SGP. In older versions of WildChests I used my own version for detecting prices out of SGP due to their laggy code. However, this caused issues with price modifiers and such. I already contacted their author and he confirmed the issue.

Thats because the amout of times the sell method is used is much less, as WC calls it many times. I will look into what can be done on my end, but it for the best results, SGP should do some improvements on their end.

HamtaBot commented 1 year ago

no you didnt undstand , when i removed wildchest shopgui plus was using 0.03, so what i am supposed to do , i contacted their support and they said its you

it seems to really be related to wildchest since when i disable the plugin shopguiplus use 0.03% so going from 14% to 0.03% it doesnt happen on older builds of wildchests

If you removed SGP and it went from 14% to 0.03%, then it is definitely an issue of SGP. In older versions of WildChests I used my own version for detecting prices out of SGP due to their laggy code. However, this caused issues with price modifiers and such. I already contacted their author and he confirmed the issue.

Thats because the amout of times the sell method is used is much less, as WC calls it many times. I will look into what can be done on my end, but it for the best results, SGP should do some improvements on their end.

alright ty , i have a ticket with them i'll try to make them optimize it

OmerBenGera commented 1 year ago

no you didnt undstand , when i removed wildchest shopgui plus was using 0.03, so what i am supposed to do , i contacted their support and they said its you

it seems to really be related to wildchest since when i disable the plugin shopguiplus use 0.03% so going from 14% to 0.03% it doesnt happen on older builds of wildchests

If you removed SGP and it went from 14% to 0.03%, then it is definitely an issue of SGP. In older versions of WildChests I used my own version for detecting prices out of SGP due to their laggy code. However, this caused issues with price modifiers and such. I already contacted their author and he confirmed the issue.

Thats because the amout of times the sell method is used is much less, as WC calls it many times. I will look into what can be done on my end, but it for the best results, SGP should do some improvements on their end.

alright ty , i have a ticket with them i'll try to make them optimize it

Great. I am also talking with Emil regarding this. I suggested him an optimization that can really help. I could theorically implement it on WildChests's side, but I think it would be the best if SGP implemented it, so all plugins that use SGP can benefit from this optimization.

I will let you know if there's an update regarding this. If you want, you can also add me to the ticket you opened.

HamtaBot commented 1 year ago

no you didnt undstand , when i removed wildchest shopgui plus was using 0.03, so what i am supposed to do , i contacted their support and they said its you

it seems to really be related to wildchest since when i disable the plugin shopguiplus use 0.03% so going from 14% to 0.03% it doesnt happen on older builds of wildchests

If you removed SGP and it went from 14% to 0.03%, then it is definitely an issue of SGP. In older versions of WildChests I used my own version for detecting prices out of SGP due to their laggy code. However, this caused issues with price modifiers and such. I already contacted their author and he confirmed the issue.

Thats because the amout of times the sell method is used is much less, as WC calls it many times. I will look into what can be done on my end, but it for the best results, SGP should do some improvements on their end.

alright ty , i have a ticket with them i'll try to make them optimize it

Great. I am also talking with Emil regarding this. I suggested him an optimization that can really help. I could theorically implement it on WildChests's side, but I think it would be the best if SGP implemented it, so all plugins that use SGP can benefit from this optimization.

I will let you know if there's an update regarding this. If you want, you can also add me to the ticket you opened.

sure how do i add you to the ticket ?

OmerBenGera commented 1 year ago

I am not sure how their system works. If you have the ability to add other discord members to the ticket, then add me. If not, maybe ask them to add me.

HamtaBot commented 1 year ago

asked them.

HamtaBot commented 1 year ago

I am not sure how their system works. If you have the ability to add other discord members to the ticket, then add me. If not, maybe ask them to add me.

you got added to it

Superalex0102 commented 1 year ago

I also have this issue, is there any updates on this?

HamtaBot commented 1 year ago

I also have this issue, is there any updates on this?

yes we have a ticket with Ome_R and the devs of shopguiplus , for now they said multiple time they are gonna fix it (talking about shhopguiplus since the issue is not on wc side) but for now its been a month with no progress

Superalex0102 commented 1 year ago

I also have this issue, is there any updates on this?

yes we have a ticket with Ome_R and the devs of shopguiplus , for now they said multiple time they are gonna fix it (talking about shhopguiplus since the issue is not on wc side) but for now its been a month with no progress

and is there a temporary fix you can recommend?

HamtaBot commented 1 year ago

nope there is not unless you fork wildchest and implement it on it temporarly

OmerBenGera commented 1 year ago

Eric (brcdev) knows about it and will hopefully get into fixing it as soon as possible.

HamtaBot commented 11 months ago

for people who wants a temp fix this commits helps a lot with lags and reduce them by 75%

OmerBenGera commented 6 months ago

FIXED