search

BG-Software-LLC / WildChests

Sell chests, auto crafters, storage units, larger chests and more in one plugin!
https://bg-software.com/wildchests/
GNU General Public License v3.0
38 stars 23 forks source link

Storage Units still accepting Slimefun cargo input #62

Closed Skizzles closed 3 years ago

Skizzles commented 3 years ago

Minecraft's Version

1.17.1 Purpur dev 1375

Plugin's Version

dev b21

Describe the bug

Slimefun cargo still sends to the barrel even when full. Slimefun has code for compatibility for this which I will include in the additional information.

To Reproduce

https://www.youtube.com/watch?v=4LurB7u6BaM

Additional Information

https://github.com/Slimefun/Slimefun4/blob/d6be483a329a3bddb2cbbedb5b7a3ddded052555/src/main/java/io/github/thebusybiscuit/slimefun4/core/networks/cargo/CargoUtils.java#L326

This was provided when I asked in the SF discord.

OmerBenGera commented 3 years ago

If it worked before, look for the latest version that it worked in, and find what they changed that broke it.

Skizzles commented 3 years ago

If it worked before, look for the latest version that it worked in, and find what they changed that broke it.

The items still send correctly to the Storage Unit so nothing is "Broken". The Storage Unit just needs compatibility with cargo for checking when the Storage Unit is full.

OmerBenGera commented 3 years ago

If it worked before, look for the latest version that it worked in, and find what they changed that broke it.

The items still send correctly to the Storage Unit so nothing is "Broken". The Storage Unit just needs compatibility with cargo for checking when the Storage Unit is full.

I don't think it's possible unless they add hard-coded support for Storage Units.