BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 12 forks source link

Structure_Engine: Add Geometry3D method for Pile, PileCap and PileFoundation #3348

Closed Chrisshort92 closed 1 month ago

Chrisshort92 commented 1 month ago

Issues addressed by this PR

Closes #3347

Geometry3D for pile and pad foundations added to Structure_Engine

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_Engine/Structure_Engine/%233347-add-geometry3d-for-piles-and-foundations/%233347-TypicalPileFoundation_Geometry3D_TestScript.gh?csf=1&web=1&e=44L3qr

Changelog

Additional comments

IsakNaslundBh commented 1 month ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 month ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 26 requests in the queue ahead of you.
IsakNaslundBh commented 1 month ago

@Chrisshort92 see the documentation compliance failures. Good to fix before merging!

Chrisshort92 commented 1 month ago

@BHoMBot check compliance

Chrisshort92 commented 1 month ago

@BHoMBot check compliance

Chrisshort92 commented 1 month ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 month ago
@Chrisshort92 to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 9 requests in the queue ahead of you.
peterjamesnugent commented 1 month ago

@BHoMBot check required

bhombot-ci[bot] commented 1 month ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 1 month ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 month ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
peterjamesnugent commented 1 month ago

@BHoMBot check unit-tests @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 month ago
@peterjamesnugent to confirm, the following actions are now queued: - check `unit-tests` - check `ready-to-merge` There are 37 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 month ago
FAO: @FraserGreenroyd @FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `25943790975`
FraserGreenroyd commented 1 month ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 25943790975

bhombot-ci[bot] commented 1 month ago
@FraserGreenroyd I have now provided a passing check on reference `25943790975` as requested.