search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 15 forks source link

Geometry_Engine: BooleanDifference secured against single-dimensional regions #3369

Closed pawelbaran closed 4 months ago

pawelbaran commented 4 months ago

Issues addressed by this PR

Closes #3368

Test files

On SharePoint.

Changelog

Additional comments

pawelbaran commented 4 months ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 4 months ago
@pawelbaran to confirm, the following actions are now queued: - check `unit-tests`
pawelbaran commented 4 months ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 4 months ago
@pawelbaran to confirm, the following actions are now queued: - check `unit-tests`
pawelbaran commented 4 months ago

Using similar approach as in https://github.com/BHoM/BHoM_Engine/pull/3364, I can confirm that result of unit-tests check in this PR here are the same as in other branches (e.g. here), so by deduction, this PR does not introduce any UT failures.

pawelbaran commented 4 months ago

@BHoMBot check required

bhombot-ci[bot] commented 4 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 4 months ago
FAO: @FraserGreenroyd @pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `27077776498`
pawelbaran commented 4 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27077776498

bhombot-ci[bot] commented 4 months ago
@pawelbaran I have now provided a passing check on reference `27077776498` as requested.
pawelbaran commented 4 months ago

@BHoMBot check dataset-compliance @BHoMBot check copyright-compliance

bhombot-ci[bot] commented 4 months ago
@pawelbaran to confirm, the following actions are now queued: - check `dataset-compliance` - check `copyright-compliance`
pawelbaran commented 4 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 4 months ago
@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge`