BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Ground_Engine: Consolidate method for a Borehole #3372

Closed peterjamesnugent closed 1 month ago

peterjamesnugent commented 2 months ago

Issues addressed by this PR

Closes #3271

Test files

https://burohappold.sharepoint.com/:u:/s/BHoM/Ed88wg7PXYJEmTkOJcxKgkgBDI2rWoJoVNS3sJPTk4iwJw?e=24SqQ2

Changelog

Additional comments

peterjamesnugent commented 2 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 months ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 2 requests in the queue ahead of you.
peterjamesnugent commented 1 month ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 month ago
@peterjamesnugent to confirm, the following actions are now queued: - check `unit-tests`
pawelbaran commented 1 month ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `unit-tests`
pawelbaran commented 1 month ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `copyright-compliance`
pawelbaran commented 1 month ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `unit-tests`
pawelbaran commented 1 month ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `unit-tests`
pawelbaran commented 1 month ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `unit-tests`
pawelbaran commented 1 month ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `unit-tests`
pawelbaran commented 1 month ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 6 requests in the queue ahead of you.
pawelbaran commented 1 month ago

@BHoMBot check core @BHoMBot check null-handling @BHoMBot check serialisation

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `core` - check `null-handling` - check `serialisation` There are 3 requests in the queue ahead of you.
pawelbaran commented 1 month ago

@BHoMBot check installer @BHoMBot check versioning

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `installer` - check `versioning` There are 2 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 month ago
FAO: @FraserGreenroyd @pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `27566220787`
pawelbaran commented 1 month ago

Dispensating the unit test check as this PR does not introduce any new failures compared to develop (e.g. here).

pawelbaran commented 1 month ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27566220787

bhombot-ci[bot] commented 1 month ago
@pawelbaran I have now provided a passing check on reference `27566220787` as requested.
pawelbaran commented 1 month ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge`