search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 15 forks source link

Diffing_Engine: Do not include static properties and fields in differences #3410

Closed IsakNaslundBh closed 1 month ago

IsakNaslundBh commented 2 months ago

Issues addressed by this PR

Closes #3406

Rule out static properties from inclusion in comparison. (see issue for a bit more detail). Minor cleanup of unused using's.

This reinstates the behaviour for testing prior to this: https://github.com/BHoM/Test_Toolkit/pull/474

Test files

Check unit-tests. This should give a not insignificant improvement in speed for running through them, especially for tests containing System.Drawing.Color.

Also, @alelom , great if you can test this through your diffing tests.

Changelog

Additional comments

Example run before this PR:

https://github.com/BHoM/BHoM_Engine/runs/29579805351

IsakNaslundBh commented 2 months ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `unit-tests`
IsakNaslundBh commented 2 months ago

@BHoMBot check serialisation

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `serialisation`
IsakNaslundBh commented 1 month ago

@BHoMBot check required @BHoMBot check compliance

bhombot-ci[bot] commented 1 month ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 1 month ago
The check `serialisation` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 month ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 month ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
IsakNaslundBh commented 1 month ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 month ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge`