BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 15 forks source link

Verifiaction: Add reference to Diffing_Engine to properly access the IsEqual method #3414

Closed IsakNaslundBh closed 2 months ago

IsakNaslundBh commented 2 months ago

Issues addressed by this PR

Closes #3413

Fixes references to the verification solution that broke after https://github.com/BHoM/Test_Toolkit/pull/474

Test files

Make sure compiles, and checks should be actually running on this PR.

Changelog

Additional comments

IsakNaslundBh commented 2 months ago

@BHoMBot check serialisation @BHoMBot check null-handling

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `serialisation` - check `null-handling`
IsakNaslundBh commented 2 months ago

@BHoMBot check required @BHoMBot check compliance

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 2 months ago
The check `serialisation` has already been run previously and recorded as a successful check. This check has not been run again at this time.
IsakNaslundBh commented 2 months ago

Will dispensate null handling on this PR, as the fact that it is failing now is a clear indication that it is now running, while before it was silently just being skipped due to the build errors on the verification solution.

For code compliance, I will also dispensate, as this is a project sitting outside the general Engine.

bhombot-ci[bot] commented 2 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 months ago
The check `project-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
IsakNaslundBh commented 2 months ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `unit-tests` There are 13 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 months ago
FAO: @adecler @pawelbaran @IsakNaslundBh @IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is code-compliance. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `29713296153`
bhombot-ci[bot] commented 2 months ago
FAO: @adecler @pawelbaran @IsakNaslundBh @IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is null-handling. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `29712010796`
IsakNaslundBh commented 2 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 29713296153

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh I have now provided a passing check on reference `29713296153` as requested.
IsakNaslundBh commented 2 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 29712010796

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh I have now provided a passing check on reference `29712010796` as requested.
IsakNaslundBh commented 2 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge`