search

BLE-LTER / MetaEgress

R package to create Ecological Metadata Language documents from an instance of LTER-core-metabase database schema
https://BLE-LTER.github.io/MetaEgress/
6 stars 3 forks source link

Customized unit #46

Open lkuiucsb opened 5 years ago

lkuiucsb commented 5 years ago

The current code doesn't work for the customized unit. For example, if you put it an unit "milligramPerGramPerHourPerPhotonFlux", the create_entity function fails.

I run the code on Mac.

lkuiucsb commented 5 years ago

I just add one thing here. The same code works on Windows. So there is something about the "set_attributes()" function from the EML 2 package doesn't work the same between Mac and PC.

atn38 commented 5 years ago

Thank you Li for the report. Can you report the error message on Macs? If you suspect it's because of set_attributes, then we should report to the EML R folks. This is potentially a bigger issue as MetaEgress isn't tested on really anything but my version of Windows yet.

On Mon, Sep 23, 2019 at 6:16 PM Li Kui notifications@github.com wrote:

I just add one thing here. The same code works on Windows. So there is something about the "set_attributes()" function from the EML 2 package doesn't work the same between Mac and PC.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BLE-LTER/MetaEgress/issues/46?email_source=notifications&email_token=AKAZD5WSSQBVBRPTSBJFMVDQLFE3PA5CNFSM4IZUUFJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MRP2Y#issuecomment-534321131, or mute the thread https://github.com/notifications/unsubscribe-auth/AKAZD5TIJB3ZURP546J53ATQLFE3PANCNFSM4IZUUFJA .

lkuiucsb commented 5 years ago

yes, probably a good idea to report to EML R team. I could do that.

lkuiucsb commented 5 years ago

There was actually an issue couple months ago about this: https://github.com/ropensci/EML/issues/278

atn38 commented 5 years ago

Thanks for taking care of it. I haven't run into this issue myself, but it seems people do run into it on Windows, not just Mac.

On Tue, Sep 24, 2019 at 3:36 PM Li Kui notifications@github.com wrote:

There was actually an issue couple months ago about this: ropensci/EML#278 https://github.com/ropensci/EML/issues/278

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BLE-LTER/MetaEgress/issues/46?email_source=notifications&email_token=AKAZD5U26OT2Q7NVNE3RGELQLJ25JA5CNFSM4IZUUFJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7PXDGI#issuecomment-534737305, or mute the thread https://github.com/notifications/unsubscribe-auth/AKAZD5UGDV6LTURJKAPGSGLQLJ25JANCNFSM4IZUUFJA .