search

BLE-LTER / MetaEgress

R package to create Ecological Metadata Language documents from an instance of LTER-core-metabase database schema
https://BLE-LTER.github.io/MetaEgress/
6 stars 3 forks source link

EDIutils 0.0.0.9000 #67

Closed clnsmth closed 2 years ago

clnsmth commented 2 years ago

Hi @atn38!

EDIutils has undergone a major refactor for submission to rOpenSci and CRAN. This new and improved version covers the full data repository REST API, handles authentication more securely, better matches API call and result syntax, improves documentation, and opens the door for development of wrapper functions to support common data management tasks. In the process of this refactor the function names and call patterns have changed and several functions supporting other EDI R packages have been removed, thereby creating back compatibility breaking changes with the previous major release (version 1.6.1). The previous version will be available until 2022-06-01 on the deprecated branch. Install the previous version with: 

remotes::install_github("EDIorg/EDIutils", ref = "deprecated")

EDIutils functions used in your code and suggested replacements

Please let me know if you have any questions, @clnsmth

gremau commented 2 years ago

I believe this is an unused reference to the EDIutils package that is present in the NAMESPACE file for the package. The line can probably be safely removed. I'm submitting pull request #68 to do this.

Without this change users who have updated to the most recent version of EDIutils (0.0.0.900) will get an error upon importing MetaEgress because R can no longer find the EDIutils function that has now been renamed (as shown above). Or at least that is what happened to me...

atn38 commented 2 years ago

Hi @gremau and @clnsmth! Just letting you know I missed this issue and was gonna open one myself after reading up on the change to EDIutils. Thanks for the alert, really appreciate it.

Colin, is the change just a name swap, no changes to inputs/outputs?

and Greg I'm setting up a new machine and ran into your exact issue as well.

clnsmth commented 2 years ago

Hi @@.***>! Yes, just a change in name. You’ll probably want to double check the output but I’m pretty sure it hasn’t changed. Thanks!

From: An @.> Sent: Thursday, February 17, 2022 3:18 PM To: BLE-LTER/MetaEgress @.> Cc: Colin Smith @.>; Mention @.> Subject: Re: [BLE-LTER/MetaEgress] EDIutils 0.0.0.9000 (Issue #67)

Hi @gremauhttps://github.com/gremau and @clnsmthhttps://github.com/clnsmth! Just letting you know I missed this issue and was gonna open one myself after reading up on the change to EDIutils. Thanks for the alert, really appreciate it. Colin, is the change just a name swap, no changes to inputs/outputs?

and Greg I'm setting up a new machine and ran into your exact issue as well.

— Reply to this email directly, view it on GitHubhttps://github.com/BLE-LTER/MetaEgress/issues/67#issuecomment-1043458387, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGCPUZPRXV5BWBV7QSC6NWDU3VQ3VANCNFSM5LXRJ64A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

atn38 commented 2 years ago

Looks the same to me! Thanks Colin, closing now.