BNFC / bnfc

BNF Converter
http://bnfc.digitalgrammars.com/
578 stars 163 forks source link

Release support for ghc 9.8.1 #469

Closed chenrui333 closed 7 months ago

chenrui333 commented 8 months ago

I saw there is a change for supporting ghc 9.8.1, can we cut a release for it? Thanks!

relates to https://github.com/Homebrew/homebrew-core/pull/153883

andreasabel commented 8 months ago

@chenrui333 , thanks for the heads up!

I saw there is a change for supporting ghc 9.8.1, can we cut a release for it? Thanks!

The Hackage-released BNFC 2.9.5 supports GHC 9.8.1, are there any problems with it?

The commit you point to is just fixes for the CI here.

Also, if you look at the diff between current masterand v2.9.5, there isn't anything of interest (no code change): https://github.com/BNFC/bnfc/compare/v2.9.5...master#files_bucket

Let me know whether this answers your request.

chenrui333 commented 7 months ago

@andreasabel I see you have updated the CI config for that change, but you actually did not release it, that is why I raised this issue :)

/private/tmp/bnfc-20231122-42886-1plkwdu/bnfc-2.9.5/dist-newstyle/sdist/bnfc-system-tests-2.9.5.0.tar.gz
Warning: Unknown/unsupported 'ghc' version detected (Cabal 3.10.1.0 supports
'ghc' version < 9.8): /opt/homebrew/opt/ghc/bin/ghc is version 9.8.1
Warning: Unknown/unsupported 'ghc' version detected (Cabal 3.10.1.0 supports
'ghc' version < 9.8): /opt/homebrew/opt/ghc/bin/ghc is version 9.8.1
chenrui333 commented 7 months ago

Actually it builds out fine now, just filed a new PR to build/test with ghc 9.8. Let's see how it goes

chenrui333 commented 7 months ago

Looks like it builds out fine now, closing the issue.

andreasabel commented 7 months ago

Excellent, thanks for the heads up!