search

BOINC / boinc

Open-source software for volunteer computing and grid computing.
https://boinc.berkeley.edu
GNU Lesser General Public License v3.0
2.03k stars 449 forks source link

[Manager] Make F1 (on focused button) consistent across Simple View and Advanced View #2458

Open JacobWKlein opened 6 years ago

JacobWKlein commented 6 years ago

On Windows, F1 is supposed to open Web Help.

However, it was discovered that, when on Advanced View, with focus on a button, F1 shows an old-style yellow tooltip first, and Web Help requires pressing F1 a second time. Simple View does not exhibit this behavior, and instead will open Web Help right away when pressing F1 with a button in focus.

My presumption is that this might be intentional, to show a tooltip for keyboard-only users, though I'm not 100% sure.

Mousing over the buttons, for both views, shows a modern tooltip (for me on Windows 10).

I propose that we make the behavior consistent for both views. Furthermore, it is my opinion that we shouldn't show the old-style yellow tooltip, and instead, F1 should immediately launch Web Help when in Advanced View focused on a button.

Thanks, Jacob

Ageless93 commented 6 years ago

As I said on the Alpha email list, it is possible that the text in the yellow box is for screen readers for visually impaired people. It is possible that these screen readers cannot read aloud the mouse-over tooltip balloons.

Also, not all buttons in Advanced view are described on the help wiki page for Advanced view. The project command buttons have their own text that won't be found on the wiki page.

AenBleidd commented 6 years ago

BTW, the text shown in Russian locale has incorrect symbols image

CharlieFenton commented 6 years ago

This behavior (displaying tooltip instead of help web page) doesn't happen on Macs. F1 is not used for help on Macs; Macs have a separate Help button on their keyboard.

Ageless93 commented 6 years ago

But I still wonder what Jacob expects of the behaviour of pressing F1 and what should open here. Especially in the cases of:

Are you expecting in both cases that the Advanced View wiki page opens? Even if for the second case there is nothing on those pages?

@CharlieFenton , what does the second case do on the Mac with the Help button?

I have downloaded NV Access, an open source screen reader for Windows which will try to read out loud anything you type, point at or F1 onto. I can tell you that it will NOT read out loud the mouse-over balloons, but it WILL read out loud the text in the yellow box.

CharlieFenton commented 6 years ago

what does the second case do on the Mac with the Help button?

It does open the Advanced View wiki page. And you have a good point that there is nothing about that button on those pages. If you hover the mouse over the button, it shows the tooltip: View your account information

JacobWKlein commented 6 years ago

When F1 is pressed in various areas of the Advanced View, it will launch a URL that has a Control ID. That eventually results in the following: https://boinc.berkeley.edu/wiki/Advanced_view

My expectation, especially in your 2 listed cases, would be to do the same.

But I understand if the "reasoning" for the current behavior (Pressing F1 while button is in focus generates a yellow tooltip) is because of accessibility reasons or screen readers.

However, that being said, I'd like some consistency - ie: Even Simple View buttons should function the same way. Look at Synchronize, Notices, Suspend, Help -- they don't exhibit the same behavior, but should, in my opinion.

That's my take. Thanks for asking/listening.

From: Jord van der Elst notifications@github.com Sent: Monday, April 16, 2018 3:28 AM To: BOINC/boinc Cc: JacobWKlein; Author Subject: Re: [BOINC/boinc] [Manager] Make F1 (on focused button) consistent across Simple View and Advanced View (#2458)

But I still wonder what Jacob expects of the behaviour of pressing F1 and what should open here. Especially in the cases of:

Are you expecting in both cases that the Advanced View wiki page opens? Even if for the second case there is nothing on those pages?

@charliehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcharlie&data=02%7C01%7C%7C4d7ed3d2da124f7cd07508d5a36b9a85%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636594604901807175&sdata=n6b8UERmKXy3WlCKul9Q4hsWrmTDXWCsJfWMAYok1Tg%3D&reserved=0, what does the second case do on the Mac with the Help button?

I have downloaded NV Accesshttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.nvaccess.org%2Fdownload%2F&data=02%7C01%7C%7C4d7ed3d2da124f7cd07508d5a36b9a85%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636594604901807175&sdata=Q4eNz2nCI6drfXhRQhZu%2BASWo%2B23oYNWnXBnOUzjE0M%3D&reserved=0, an open source screen reader for Windows which will try to read out loud anything you type, point at or F1 onto. I can tell you that it will NOT read out loud the mouse-over balloons, but it WILL read out loud the text in the yellow box.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBOINC%2Fboinc%2Fissues%2F2458%23issuecomment-381505036&data=02%7C01%7C%7C4d7ed3d2da124f7cd07508d5a36b9a85%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636594604901807175&sdata=IBYccg4Zq2bnPP0kALevMuf%2BkURBZ658V6H3ssEcG9A%3D&reserved=0, or mute the threadhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMpzVyRuHhvrkh6EVr05Vnhl1-X9POfmks5tpEgIgaJpZM4TMu-r&data=02%7C01%7C%7C4d7ed3d2da124f7cd07508d5a36b9a85%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636594604901807175&sdata=mE2d3bxqWp5CV%2BlP5N9sUz%2Bc%2BJG5UHy7JvkNzQGotYY%3D&reserved=0.