BU-ISCIII / iskylims

is an open-source LIMS (laboratory Information Management System) for Next Generation Sequencing sample management, statistics and reports, and bioinformatics analysis service management.
https://github.com/BU-ISCIII/iSkyLIMS/wiki
GNU General Public License v3.0
72 stars 34 forks source link

Error in list of ongoing services in drylab home #299

Open saramonzon opened 2 months ago

saramonzon commented 2 months ago

Description of the bug

The list of ongoing services is supposed to collect data from services ongoing, now archived and rejected services are shown on this list.

We need to exclude "archive and rejected" in this query: https://github.com/BU-ISCIII/iskylims/blob/bdd3781d29b29f123f1bf6baa31c920f9fb959a2/drylab/views.py#L50-L55

Also estimated delivery date is not shown, "None" is displayed.

I see that we use the get_delivery_date method from the Service object: https://github.com/BU-ISCIII/iskylims/blob/bea0875a901586ed830516b8073fb968ff561709/drylab/models.py#L326-L333

We should rename this as get_delivered_date, this date is only filled once the service is actually derivered. Here we need to get the estimated delivery date from the RESOLUTION. Maybe it is easier to change the query from the Service table to the Resolution table and display resolution id instead of service id, and its estimated delivery date.

Command used and terminal output

No response

Relevant files

No response

System information

iskylims v3.0.0