search

BUStools / bustools

Tools for working with BUS files
https://bustools.github.io/
BSD 2-Clause "Simplified" License
92 stars 23 forks source link

Possible to use liblbfgs instead? #72

Open nileshpatra opened 3 years ago

nileshpatra commented 3 years ago

Hi,

Thanks for your work on bustools.

Bit of context: When I was updating the corresponding bustools in Debian to latest upstream, I noticed that there are new dependencies being vendored in "dependencies/" dir.

Since shipping code copies isn't the best for us as a distribution, I patched the build system to use packaged libraries instead. eigen3 was already packages, I packaged cppnumericalsolvers and uploaded -- all good till now.

Now, the library "LBFGSpp" looks like it is a fork of liblbfgs. Now, liblbfgs is a package in the distribution already, and packaging a fork is more or less always suboptimal.

Now: Hence, would it be possible for you to somehow patch stuff to use the original lib instead of fork?

I also opened an issue on LBFGSpp repository to see the possibility of they merging their code in liblbfgs. But since they have diverged quite a bit, this looks a little hard to get going. Hence, is there a possibility for you to use the original one instead of the fork?

nileshpatra commented 3 years ago

CC: @pmelsted @johan-gson

johan-gson commented 3 years ago

Hi,

Thank you for the suggestion. We however have no plans to change this. For us it is important that building bustools is robust and always works - this is why the dependencies are added to the repository, and that we hence can trust that the code works regardless of any changes made to the original repositories. Sorry for any inconvenience this may cause.