Improvements/3.0

[vitorvicente]

Version 3.0 of Inquisitor

This Pull Request includes a plethora of changes/additions/fixes, all in an effort to release the Third Major Version of the Inquisitor Software.

Changes

UI

The main focus of this new Version is an improved UI for Inquisitor, for a visual guide see the links below. Major changes include - removal of a NavBar in favor of a landing page with Action Cards that show/disappear according to the current Settings/Application status.

Pages now follow a pretty standard UI Theme (although no Theme is used, rather Styled Components, this is in an effort to fix a bug with Dark Mode). A new Header and improved looks of side-navbars are also included, in a much smoother and rounded look.

• Landing Page for non-logged Users
• Landing Page for Applicants
• Landing Page for Recruitment Team + Admin
• Landing Page for Non-Recruitment Team UPE Members
• Apply Page
• Timeslot Selection for Applicants
• Timeslot Selection for Interviewers
• Interview Room for Applicants
• Base Interview Room for Interviewers
• Selected Interview Room for Interviewers
• Deliberations Must Complete Interview for Applicants
• Deliberations Underway Page for Applicants
• Deliberations Rejected Email Warning for Applicants
• Deliberations Provisional Acceptance for Applicants
• Deliberation Official Acceptance for Applicants
• Deliberation More Info for Applicants
• Deliberations All Set for Applicants
• Base Deliberation Page for UPE-Members + Admins
• Add Feedback Page for Admins
• Second Round Status Page for Admins
• Applicant Vote Page p.1
• Applicant Vote Page p.2
• Applicant Vote Page p.3
• Applicant Vote Page Second Round
• Interest Form Page
• 404 Page
• Admin General Settings p.1
• Admin General Settings p.2
• Admin Configure App
• Admin View Apps
• Admin Manage Timeslots
• Admin Manage Questions
• Admin Manage Levels
• Admin Manage Interviews
• Admin Manage Events

Notes on Screenshots

Due to screen limitations, some screenshots might be missing the footer or the header, but it is there! It might also be the case that the pages are very zoomed out.

For Landing Page, I can't get every card there because some contradict each other (New Application vs Edit Application vs Interest Form), but they are basically the same style.

Three pages are missing, since they are mostly a step and done functional page: Events, Login, Logout. All three have UIs though.

Manage Interviews

There is a new Admin Functionality that allows Admins to close an interview, or mark the applicant as a no-show, this fixes issues we had in the past with no-shows and single interviewer interviews.

Recruitment Events

There is a new General Functionality to mark attendance for Recruitment Events with Inquisitor, this includes an Admin Panel to create and Manage Events; and an Applicant Events page to register the user as attending via URL parameters given by a specially generated QR code.

Name Changes

We are finally sticking with the name and URL Inquisitor!!

General Fixes

This version fixes a bunch of issues, all of which can be found in the Issues tab here on Github.

[vitorvicente]

Have to merge because of Splash 2.0

[ROODAY]

Np, I'll still give it a look through and provide some comments later

[ROODAY]

Also here are some comments on design/styling. Take these with a grain of salt as it's just me.

• Landing Page for non-logged Users
  • As mentioned in the code review, the text above and below the logo in the image gets cutoff. I'd suggest making the image less noisy/just the logo and make sure the logo is always in view
  • I also think the navbar should come back and replace the list of action cards, because the header and body of each card just repeat the same information (e.g. Login and Click the link below to login doesn't give the user more information, and the the Go! button feels redundant, when it could just be a button with Login, Contact Us, etc.). Navigation in the navbar is more intuitive as most apps/sites do that, and then it would clear space to add different content (not sure what that content could be, you could even do a full page image if you wanted to fill the space)
• Landing Page for Applicants
  • Same as above, the list of action cards is too verbose imo whereas the navbar could show this more compactly
• Landing Page for Recruitment Team + Admin
  • Same as above
• Landing Page for Non-Recruitment Team UPE Members
  • Same as above

For the rest of these pages, I think the image shouldn't be visible at the top, as it's wasted space that distracts from the main point of the page, e.g. applying or selecting timeslots, etc. The image should be used for grabbing attention on the landing page, but once they're in the app we should focus on interactable bits.

• Apply Page
• Timeslot Selection for Applicants
• Timeslot Selection for Interviewers
• Interview Room for Applicants
• Base Interview Room for Interviewers
  • The red text on black sidebar is a bit hard on the eyes
  • Also the floating sidebar (not connected to left side or footer) looks a little weird to me
• Selected Interview Room for Interviewers
  • Same as above
• Deliberations Must Complete Interview for Applicants
• Deliberations Underway Page for Applicants
• Deliberations Rejected Email Warning for Applicants
• Deliberations Provisional Acceptance for Applicants
  • The confirm button is really big, I think here the content can be centered and have a normal sized button
• Deliberation Official Acceptance for Applicants
  • Same as above
• Deliberation More Info for Applicants
  • To make better use of the space, you could use a 2 column layout, with next steps on the left and the data form on the right, and collapse it to 1 column on small screens/mobile
• Deliberations All Set for Applicants
• Base Deliberation Page for UPE-Members + Admins
  • Same comments as the base interview room page, the red text on black background could use some more contrast (maybe a brighter red? not sure), and the floating sidebar looks strange
  • This is true for all the deliberation screenshots below
• Add Feedback Page for Admins
• Second Round Status Page for Admins
• Applicant Vote Page p.1
• Applicant Vote Page p.2
• Applicant Vote Page p.3
• Applicant Vote Page Second Round
• Interest Form Page
• 404 Page
• Admin General Settings p.1
  • Same comments on the sidebar as earlier
• Admin General Settings p.2
• Admin Configure App
• Admin View Apps
• Admin Manage Timeslots
  • The buttons at the top shouldn't be full width, they should just be large enough for their text, and can sit side by side
• Admin Manage Questions
  • The questions look a bit cluttered, they could use some margin between cards
• Admin Manage Levels
• Admin Manage Interviews
• Admin Manage Events

And last comment that applies to the app in general, I'm not sure if I agree with the font change. Correct me if I'm wrong but is the idea to make the app look more classy/honor society like? I'm not against that, I just think that serif fonts in general tend to make things look old timey, and it's a fine line from classy to looking outdated.

In all honesty I think getting a professional designer to talk with eboard, figure out what the design goals are, and then iterate until they can agree on a design, would be the best move. Perhaps Ziba could help with funding, make it a win/win scenario by having a design student from BU do it so it's cheaper and they can put it on their portfolio (I think they should be paid because otherwise they won't be trying their hardest). In general I can only comment on what looks off to me, but I'm not a professional designer so I'd say defer to one of those.