Need a validation test for depth prepass.

BabylonJS / BabylonNative

Build cross-platform native applications with the power of the Babylon.js JavaScript framework

MIT License

765 stars 132 forks source link

Need a validation test for depth prepass. #778

Open rgerd opened 3 years ago

rgerd commented 3 years ago

It was recently discovered (https://github.com/BabylonJS/Babylon.js/pull/10466) that the needDepthPrePass material property was causing the depth buffer to block the following opaque/color rendering step. We should consider adding a validation test to make sure this isn't broken in the future.

The relevant code in renderingGroup.ts

CedricGuillemet commented 3 years ago

Some documentation is available in this PR so anyone can add a new test scene : https://github.com/BabylonJS/BabylonNative/pull/780

bghgary commented 2 years ago

@CedricGuillemet Can you check if there is a test on the Babylon.js side that tests this?

CedricGuillemet commented 1 year ago

None of the prepass/SSAO VT are working. I think it needs https://github.com/BabylonJS/BabylonNative/issues/939 to be fixed before continuing the work.