search

Backupiseasy / ThreatPlates

Nameplate addon for World of Warcraft
https://wow.curseforge.com/projects/tidy-plates-threat-plates
35 stars 18 forks source link

nameplate resource on target #523

Open arise555 opened 4 weeks ago

arise555 commented 4 weeks ago

When I display the personal resource bar on target of a nameplate, the personal resource bar is covered by the nameplate when multiple nameplates overlap. When I use the blizzard default nameplate, the resource bar is not covered by the other nameplates. I would like to know how to fix it.

Backupiseasy commented 3 weeks ago

I can look at that, but I don't think that this can be fixed. Basically, it depends on the layer (frame strata) at which nameplates are shown which is BACKGROUND for TP. Which is already the lowest one. There are also frame levels, so it's a bit more complicated.

arise555 commented 3 weeks ago

Unfortunately I can't give up the best plate addon for this small issue so I'm going to compromise by using widget combo points. Thanks for the answer.

Backupiseasy commented 3 weeks ago

So, your resources will be shown in front if you change one one in TidyPlatesCore.lua:

491: local extended = _G.CreateFrame("Frame", "ThreatPlatesFrame" .. GetNameForNameplate(plate), WorldFrame)

to

491: local extended = _G.CreateFrame("Frame", "ThreatPlatesFrame" .. GetNameForNameplate(plate), plate)

After that, the parent frame of the nameplate is no longer the WorldFrame, but the (hidden) Blizzard nameplate. This will mess up some stuff like alpha and scaling as Threat Plates will no also , e..g, scale with Blizzard nameplates (which they normally not do). That's why I never changed that. There might be other side effects, not sure.

I'll play around with this a bit and see if the side effects can be removed or suppressed.

arise555 commented 3 weeks ago

Thank you for your response.

I just applied it and got very satisfactory results.

I'm Korean and English is not my first language, so I'll have a hard time communicating this When I used the omniauras addon and threat plate together, When pinning the omniaurs icon to the left of the threat plate nameplate, the omniauras icon slightly overlapped the left side of the threaplate when no target was selected.

So i tried adjusting the scaling settings in threat plate but that didn't fix it and then i thought omniaruas was following the bliazzard default nameplate and i changed the nameplateminscale 0.8 value to 1 in the cvar settings and that fixed it.

This means that the scaling setting is different from the bliazzard default nameplate, as you said. Also, after modifying as you suggested, the blizzard default nameplate and threat plate are now synchronized.

The personal resource bar no longer overlaps the other nameplate. Also, i don't need to replace the nameplateminscale 0.8 value with 1 in the cvar settings.

I realize that patching it will cause confusion because some people have the old setup.