Backupiseasy / ThreatPlates

Nameplate addon for World of Warcraft
https://wow.curseforge.com/projects/tidy-plates-threat-plates
37 stars 23 forks source link

Feral druid considered healer #558

Open alexandersoto opened 1 month ago

alexandersoto commented 1 month ago

Feral druids are showing up as a healer when the healer tracker widget is enabled.

KrassusGit commented 1 month ago

this has been an issue since DF

VanCoGaming commented 1 month ago

Hi Guys

Any update on this issue. It is super annoying seeing this.

I feel the widget as a hole is a little buggy when it comes to placement on health bar view and headline view.

All i care about though is removing the marker on classes that are not healers.

Ty for the great addon though my dudes

Backupiseasy commented 1 month ago

Currently, the following spells are used to detect a druid healer:

  [33763] = "DRUID", -- Lifebloom
  --[17116] = "DRUID", -- Nature's Swiftness
  [102351] = "DRUID", -- Cnenarion Ward
  [33763] = "DRUID", -- Nourish
  [81262] = "DRUID", -- Efflorescence
  --[740] = "DRUID", -- Tranquility
  --[102342] = "DRUID", -- Ironbark
  --[203651] = "DRUID", -- Overgrowth
  --[33891] = "DRUID", -- Incarnation: Tree of Life
  --[391528] = "DRUID", -- Convoke the Spirits
  [391888] = "DRUID", -- Adaptive Swarm -- Shared with Feral
  --[197721] = "DRUID", -- Flourish
  [392160] = "DRUID", -- Invigorate

I need to rework that and only keep spells that a Druid healer can use.

In BGs, also the spec information is used. Maybe that should take priority. Currently, the first info source (spell, scoreboard) wins.

Backupiseasy commented 1 month ago

After some checking, I think for Druid the following should work, what do you mean?

  [33763] = "DRUID",   -- Lifebloom
  --[132158] = "DRUID",  -- Nature's Swiftness
  --[102351] = "DRUID",  -- Cenarion Ward
  [145205] = "DRUID",  -- Efflorescence
  --[740] = "DRUID",     -- Tranquilit
  --[102342] = "DRUID",  -- Ironbark
  --[50464] = "DRUID",   -- Nourish
  --[102693] = "DRUID",  -- Grove Guardians
  --[203651] = "DRUID",  -- Overgrowth
  --[33891] = "DRUID",   -- Incarnation: Tree of Life
  --[391528] = "DRUID",  -- Convoke the Spirits
  --[392160] = "DRUID",  -- Invigorate
  --[197721] = "DRUID",  -- Flourish
  [18562] = "DRUID",   -- Swiftmend
  [212040] = "DRUID",  -- Revitalize

I did not use spells with longer cooldowns or that are optional. What do you think? Does that look ok?

I also need to update the other healing specs, obviously.

Backupiseasy commented 1 month ago

Healer Tracker is now updated in version 12.0.10. If a spec is still wrongly shown as healer, please report here.

KrassusGit commented 1 month ago

thank you!

KrassusGit commented 3 weeks ago

ran into an issue again today, now Balance druids are considered healers

Backupiseasy commented 3 weeks ago

Still on retail, right?

KrassusGit commented 3 weeks ago

yes sir

Backupiseasy commented 2 weeks ago

The spells should be correct, I cannot find a spell that Balance druids are able to cast that would mark them as healers. I can imagine one situation where the Healer Tracker is not accurate: If this is in a battleground and the druid enters as Resto, casts a spell on the list or is immediately recognized as heal spec, then from that point on, that does not change, even if the druid switches spec to Balance afterwards.

That's not easily solvable, but at least some improvements are possible, e.g.,, ignoring the spell detection if there is a valid spec information in BGs.

Did you see this druid in a BG or in the open world?

KrassusGit commented 2 weeks ago

in a BG, I'll upload a screenshot WoWScrnShot_110424_225900