search

Bacon / BaconQrCode

QR Code Generator for PHP
BSD 2-Clause "Simplified" License
1.82k stars 208 forks source link

BUG? on this line $j is always 0, isn't this meant to be $i ? or actually 0? #147

Closed alien999999999 closed 12 months ago

alien999999999 commented 12 months ago

https://github.com/Bacon/BaconQrCode/blob/8eba389da071f396d71ddf034289093b9e4e9cae/src/Common/ReedSolomonCodec.php#L176C38-L176C38

DASPRiD commented 12 months ago

Actually, this is correct by accident: https://github.com/quiet/libfec/blob/master/init_rs.h#L99

Feel free to PR a replacement to 0 ;)

alien999999999 commented 12 months ago

yeah, after looking at the code some more, i got to the same conclusion that it is meant to be 0