Pull/Merge Approval Flow

Bad-Developers-Troop / polarisdesk

4 stars 8 forks source link

Pull/Merge Approval Flow #4

Open abbadon1334 opened 3 years ago

abbadon1334 commented 3 years ago

Activated branch protection for dev/main to avoid, independent push and merge.
At least 2 reviewers need to approve the PR before merging.
[ ] To review and approve the PR quickly and only from a conceptual point of view and don't lose time doing local functional testing, we need to add branches protection with UnitTest.

Anyone can auto-assign this task and transform this issue into a PR.

@kasuken is the only one who can bypass this restriction to avoid live coding problem, it's already too good in chaos creation.

binick commented 3 years ago

Hi @abbadon1334, do you have a preference about:

which build system?
unit testing libraries your want to use?

If your want integrate CI/CD practices this issues can be related to #10.

abbadon1334 commented 3 years ago

Hi @abbadon1334, do you have a preference about:

which build system?

unit testing libraries your want to use?

If your want integrate CI/CD practices this issues can be related to #10.

Part of those tasks was assigned during live to @paranoiasystem, you can reach us and @paranoiasystem joining discord

Morati81 commented 3 years ago

Hi @abbadon1334 ,

this is something that only repo owner or someone with admin permission can do.

see here https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuring-protected-branches as a reference.

abbadon1334 commented 3 years ago

Hi @abbadon1334 ,

this is something that only repo owner or someone with admin permission can do.

see here https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuring-protected-branches as a reference. Hi @Morati81 thanks for the link! we have already done that.