BahamutDragon / pcgen

PCGen Data Sets
308 stars 337 forks source link

Holy Weapon bug #831

Closed ColdStubby closed 6 years ago

ColdStubby commented 6 years ago

When Holy weapon equipped, get error message: "Unable to process sheet java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Requested ScopeInstance for pcgen.core.EquipmentModifier Holy (Weapon/Melee) and reached a global parent, but have only reached Scope: EQUIPMENT" when the character sheet is created.

The log is: 23:29:23.650 INFO main Main:140 Starting PCGen v6.07.08 23:29:23.697 INFO main LanguageBundle:134 Initialising language bundle with locale en_GB. 23:34:01.291 INFO Thread-6 SourceFileLoader:567 Loading game Bahamut35e and sources [Arms and Equipment Guide, Complete Adventurer, Complete Arcane, Complete Champion, Complete Divine, Complete Mage, Complete Scoundrel, Complete Warrior, Dungeon Master's Guide II, Dungeons & Dragons - Core Books, Expanded Psionics Handbook, Magic Item Compendium, Monster Manual II, Monster Manual III, Player's Handbook II, Races of Destiny, Races of Stone, Races of the Wild, Spell Compendium, Unearthed Arcana (Complete)]. 23:34:09.494 SEVERE Thread-6 CDOMFactory:106 Unconstructed Reference: EquipmentModifier MWORKA 23:34:09.494 SEVERE Thread-6 TrackingReferenceContext:104 Was used in file:/D:/Users/Stuart/PCGen/6.07.08/6.07.08/data/35e/wizards_of_the_coast/supplement/races_of_the_wild/rw_equip.lst in tokens: [plugin.lsttokens.equipment.EqmodToken] 23:34:09.494 SEVERE Thread-6 TrackingReferenceContext:104 Was used in file:/D:/Users/Stuart/PCGen/6.07.08/6.07.08/data/35e/wizards_of_the_coast/supplement/races_of_the_wild/rw_equipmods.lst in tokens: [plugin.lsttokens.equipmentmodifier.ReplacesToken] 23:34:09.650 SEVERE Thread-6 AbilityCategory:697 Unconstructed Reference: Ability Category Special Ability Uncanny Dodge 23:34:22.153 INFO AWT-EventQueue-0 CharacterManager:100 Created new character Unnamed 1. 23:35:33.509 INFO AWT-EventQueue-0 CharacterFacadeImpl:1890 Test: Setting race to Gnome 23:35:45.431 INFO AWT-EventQueue-0 CharacterFacadeImpl:820 Test: Adding level 1 in class Cleric 23:40:44.386 SEVERE AWT-EventQueue-0 CharacterSheetPanel:169 Unable to process sheet: java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Requested ScopeInstance for pcgen.core.EquipmentModifier Holy (Weapon/Melee) and reached a global parent, but have only reached Scope: EQUIPMENT at java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.util.concurrent.FutureTask.get(FutureTask.java:192) at pcgen.gui2.csheet.CharacterSheetPanel$RefreshTask.lambda$done$0(CharacterSheetPanel.java:159) at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756) at java.awt.EventQueue.access$500(EventQueue.java:97) at java.awt.EventQueue$3.run(EventQueue.java:709) at java.awt.EventQueue$3.run(EventQueue.java:703) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80) at java.awt.EventQueue.dispatchEvent(EventQueue.java:726) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) at java.awt.EventDispatchThread.run(EventDispatchThread.java:82) Caused by: java.lang.IllegalArgumentException: Requested ScopeInstance for pcgen.core.EquipmentModifier Holy (Weapon/Melee) and reached a global parent, but have only reached Scope: EQUIPMENT at pcgen.base.formula.inst.SimpleScopeInstanceFactory.getMessaged(SimpleScopeInstanceFactory.java:161) at pcgen.base.formula.inst.SimpleScopeInstanceFactory.getMessaged(SimpleScopeInstanceFactory.java:189) at pcgen.base.formula.inst.SimpleScopeInstanceFactory.get(SimpleScopeInstanceFactory.java:125) at pcgen.cdom.facet.ScopeFacet.get(ScopeFacet.java:68) at pcgen.cdom.facet.ScopeFacet.get(ScopeFacet.java:84) at pcgen.cdom.facet.GrantedVarFacet.dataRemoved(GrantedVarFacet.java:106) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:267) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:205) at pcgen.cdom.facet.base.AbstractSourcedListFacet.processRemoval(AbstractSourcedListFacet.java:500) at pcgen.cdom.facet.base.AbstractSourcedListFacet.remove(AbstractSourcedListFacet.java:147) at pcgen.cdom.facet.CDOMObjectConsolidationFacet.remove(CDOMObjectConsolidationFacet.java:93) at pcgen.cdom.facet.CDOMObjectConsolidationFacet.dataRemoved(CDOMObjectConsolidationFacet.java:160) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:267) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:205) at pcgen.cdom.facet.base.AbstractSourcedListFacet.processRemoval(AbstractSourcedListFacet.java:500) at pcgen.cdom.facet.base.AbstractSourcedListFacet.remove(AbstractSourcedListFacet.java:147) at pcgen.cdom.facet.EquipmentConsolidationFacet.dataRemoved(EquipmentConsolidationFacet.java:89) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:267) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:205) at pcgen.cdom.facet.base.AbstractSourcedListFacet.processRemoval(AbstractSourcedListFacet.java:500) at pcgen.cdom.facet.base.AbstractSourcedListFacet.remove(AbstractSourcedListFacet.java:147) at pcgen.cdom.facet.model.ActiveEqModFacet.dataRemoved(ActiveEqModFacet.java:54) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:267) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:205) at pcgen.cdom.facet.base.AbstractSourcedListFacet.processRemoval(AbstractSourcedListFacet.java:500) at pcgen.cdom.facet.base.AbstractSourcedListFacet.remove(AbstractSourcedListFacet.java:147) at pcgen.cdom.facet.model.ActiveEqHeadFacet.dataRemoved(ActiveEqHeadFacet.java:50) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:267) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:205) at pcgen.cdom.facet.base.AbstractSourcedListFacet.removeAll(AbstractSourcedListFacet.java:216) at pcgen.core.PlayerCharacter.clone(PlayerCharacter.java:7257) at pcgen.gui2.facade.CharacterFacadeImpl.getExportCharacter(CharacterFacadeImpl.java:2620) at pcgen.gui2.facade.CharacterFacadeImpl.export(CharacterFacadeImpl.java:2651) at pcgen.gui2.csheet.CharacterSheetPanel$DocumentConstructor.call(CharacterSheetPanel.java:190) at pcgen.gui2.csheet.CharacterSheetPanel$DocumentConstructor.call(CharacterSheetPanel.java:184) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748)

FerretDave commented 6 years ago

Greetings, I'd recently spotted an MWORKA and Uncanny Dodge error - I've submitted a PR to fix it, however I was looking at forgotten Realms stuff, however it may that the same fix is needed across the various 'Complete xxx' works too

Always worth checking for any source load errors (red dot bottom right of GUI) before working on any characters - if the sources are not loading correctly, then the character could end up with dubious configuration.

No idea on the Holy Weapon issue though, sorry.

Cheers Dave

On Sat, 8 Sep 2018 at 23:48, ColdStubby notifications@github.com wrote:

When Holy weapon equipped, get error message: "Unable to process sheet java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Requested ScopeInstance for pcgen.core.EquipmentModifier Holy (Weapon/Melee) and reached a global parent, but have only reached Scope: EQUIPMENT" when the character sheet is created.

The log is: 23:29:23.650 INFO main Main:140 Starting PCGen v6.07.08 23:29:23.697 INFO main LanguageBundle:134 Initialising language bundle with locale en_GB. 23:34:01.291 INFO Thread-6 SourceFileLoader:567 Loading game Bahamut35e and sources [Arms and Equipment Guide, Complete Adventurer, Complete Arcane, Complete Champion, Complete Divine, Complete Mage, Complete Scoundrel, Complete Warrior, Dungeon Master's Guide II, Dungeons & Dragons

  • Core Books, Expanded Psionics Handbook, Magic Item Compendium, Monster Manual II, Monster Manual III, Player's Handbook II, Races of Destiny, Races of Stone, Races of the Wild, Spell Compendium, Unearthed Arcana (Complete)]. 23:34:09.494 SEVERE Thread-6 CDOMFactory:106 Unconstructed Reference: EquipmentModifier MWORKA 23:34:09.494 SEVERE Thread-6 TrackingReferenceContext:104 Was used in file:/D:/Users/Stuart/PCGen/6.07.08/6.07.08/data/35e/wizards_of_the_coast/supplement/races_of_the_wild/rw_equip.lst in tokens: [plugin.lsttokens.equipment.EqmodToken] 23:34:09.494 SEVERE Thread-6 TrackingReferenceContext:104 Was used in file:/D:/Users/Stuart/PCGen/6.07.08/6.07.08/data/35e/wizards_of_the_coast/supplement/races_of_the_wild/rw_equipmods.lst in tokens: [plugin.lsttokens.equipmentmodifier.ReplacesToken] 23:34:09.650 SEVERE Thread-6 AbilityCategory:697 Unconstructed Reference: Ability Category Special Ability Uncanny Dodge 23:34:22.153 INFO AWT-EventQueue-0 CharacterManager:100 Created new character Unnamed 1. 23:35:33.509 INFO AWT-EventQueue-0 CharacterFacadeImpl:1890 Test: Setting race to Gnome 23:35:45.431 INFO AWT-EventQueue-0 CharacterFacadeImpl:820 Test: Adding level 1 in class Cleric 23:40:44.386 SEVERE AWT-EventQueue-0 CharacterSheetPanel:169 Unable to process sheet: java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Requested ScopeInstance for pcgen.core.EquipmentModifier Holy (Weapon/Melee) and reached a global parent, but have only reached Scope: EQUIPMENT at java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.util.concurrent.FutureTask.get(FutureTask.java:192) at pcgen.gui2.csheet.CharacterSheetPanel$RefreshTask.lambda$done$0(CharacterSheetPanel.java:159) at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756) at java.awt.EventQueue.access$500(EventQueue.java:97) at java.awt.EventQueue$3.run(EventQueue.java:709) at java.awt.EventQueue$3.run(EventQueue.java:703) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80) at java.awt.EventQueue.dispatchEvent(EventQueue.java:726) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) at java.awt.EventDispatchThread.run(EventDispatchThread.java:82) Caused by: java.lang.IllegalArgumentException: Requested ScopeInstance for pcgen.core.EquipmentModifier Holy (Weapon/Melee) and reached a global parent, but have only reached Scope: EQUIPMENT at pcgen.base.formula.inst.SimpleScopeInstanceFactory.getMessaged(SimpleScopeInstanceFactory.java:161) at pcgen.base.formula.inst.SimpleScopeInstanceFactory.getMessaged(SimpleScopeInstanceFactory.java:189) at pcgen.base.formula.inst.SimpleScopeInstanceFactory.get(SimpleScopeInstanceFactory.java:125) at pcgen.cdom.facet.ScopeFacet.get(ScopeFacet.java:68) at pcgen.cdom.facet.ScopeFacet.get(ScopeFacet.java:84) at pcgen.cdom.facet.GrantedVarFacet.dataRemoved(GrantedVarFacet.java:106) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:267) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:205) at pcgen.cdom.facet.base.AbstractSourcedListFacet.processRemoval(AbstractSourcedListFacet.java:500) at pcgen.cdom.facet.base.AbstractSourcedListFacet.remove(AbstractSourcedListFacet.java:147) at pcgen.cdom.facet.CDOMObjectConsolidationFacet.remove(CDOMObjectConsolidationFacet.java:93) at pcgen.cdom.facet.CDOMObjectConsolidationFacet.dataRemoved(CDOMObjectConsolidationFacet.java:160) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:267) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:205) at pcgen.cdom.facet.base.AbstractSourcedListFacet.processRemoval(AbstractSourcedListFacet.java:500) at pcgen.cdom.facet.base.AbstractSourcedListFacet.remove(AbstractSourcedListFacet.java:147) at pcgen.cdom.facet.EquipmentConsolidationFacet.dataRemoved(EquipmentConsolidationFacet.java:89) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:267) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:205) at pcgen.cdom.facet.base.AbstractSourcedListFacet.processRemoval(AbstractSourcedListFacet.java:500) at pcgen.cdom.facet.base.AbstractSourcedListFacet.remove(AbstractSourcedListFacet.java:147) at pcgen.cdom.facet.model.ActiveEqModFacet.dataRemoved(ActiveEqModFacet.java:54) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:267) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:205) at pcgen.cdom.facet.base.AbstractSourcedListFacet.processRemoval(AbstractSourcedListFacet.java:500) at pcgen.cdom.facet.base.AbstractSourcedListFacet.remove(AbstractSourcedListFacet.java:147) at pcgen.cdom.facet.model.ActiveEqHeadFacet.dataRemoved(ActiveEqHeadFacet.java:50) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:267) at pcgen.cdom.facet.base.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:205) at pcgen.cdom.facet.base.AbstractSourcedListFacet.removeAll(AbstractSourcedListFacet.java:216) at pcgen.core.PlayerCharacter.clone(PlayerCharacter.java:7257) at pcgen.gui2.facade.CharacterFacadeImpl.getExportCharacter(CharacterFacadeImpl.java:2620) at pcgen.gui2.facade.CharacterFacadeImpl.export(CharacterFacadeImpl.java:2651) at pcgen.gui2.csheet.CharacterSheetPanel$DocumentConstructor.call(CharacterSheetPanel.java:190) at pcgen.gui2.csheet.CharacterSheetPanel$DocumentConstructor.call(CharacterSheetPanel.java:184) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BahamutDragon/pcgen/issues/831, or mute the thread https://github.com/notifications/unsubscribe-auth/AGNF3dZB5nbUNGH-d7vxFRmY59CC7Okeks5uZEkngaJpZM4WgD49 .

-- oxxxxxxx{;;;;;;;;;;;;;;;;;;;;;;;;;;;;;>

ColdStubby commented 6 years ago

Dave, thanks for the response, I didn't even know that the red dot at the bottom right of the GUI represented this - that's helpful to know. Half of my problem is that I don't know how the app hangs together, otherwise I could help more. I'm trying to work it out, but still have a lot to learn.

Cheers, Stuart

FerretDave commented 6 years ago

Greetings

There are a few tutorial lessons available online if you want to get into list coding, it is lightweight coding effectively with an easy syntax.

Certainly reading or watching a couple will help you debug issues, even if you still log them for others to fix.

Essentially it is all text files and tab seperated bits of info, one line per entry. Every 'source' you load via the gui is a '.pcc' file that defines several '.lst' files to load.

If you try being more selective with the sources you load, by trial and error you could track down which source introduces the error and thus make it easier to resolve.

Cheers Dave

On Sun, 9 Sep 2018 at 01:38, ColdStubby notifications@github.com wrote:

Dave, thanks for the response, I didn't even know that the red dot at the bottom right of the GUI represented this - that's helpful to know. Half of my problem is that I don't know how the app hangs together, otherwise I could help more. I'm trying to work it out, but still have a lot to learn.

Cheers, Stuart

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/BahamutDragon/pcgen/issues/831#issuecomment-419682325, or mute the thread https://github.com/notifications/unsubscribe-auth/AGNF3SloBrfJBHwI6_TYfB4z3t5fHCoSks5uZGMegaJpZM4WgD49 .

-- oxxxxxxx{;;;;;;;;;;;;;;;;;;;;;;;;;;;;;>

ColdStubby commented 6 years ago

I'll fix the MWORKA and Uncanny Dodge issues with the sources I'm loading. Thanks for the help.

Cheers, Stuart

ColdStubby commented 6 years ago

Created pull request to fix the MWORKA and Uncanny Dodge issues I experienced. The holy weapon issue is still not resolved.

BahamutDragon commented 6 years ago

It is not just the homebrew files that create the error message. This is a central code issue with the PCGen program.

LegacyKing commented 6 years ago

Hey all, I don't normally jump on here. But this has been a hit or miss bug on our side of the fence.

I wrangled a code monkey to take a look at it this week, but cannot reproduce with our own sources.

Can someone attach a character file with this bug to our TRACKER here --> https://pcgenorg.atlassian.net/browse/CODE-3253

or send the file to me HELP@PCGen.org.

Cheers,

LegacyKing commented 6 years ago

I figured out your issue. Two items with the exact same name, but different KEY causes pcgen to fail when it tries to add both. Remove your old "Holy" and all the other old items.

Cheers,

FerretDave commented 6 years ago

Greetings

Thanks for figuring it out 😀

Cheers D

On Sun, 9 Sep 2018 at 22:24, Andrew Maitland notifications@github.com wrote:

I figured out your issue. Two items with the exact same name, but different KEY causes pcgen to fail when it tries to add both. Remove your old "Holy" and all the other old items.

Cheers,

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/BahamutDragon/pcgen/issues/831#issuecomment-419746028, or mute the thread https://github.com/notifications/unsubscribe-auth/AGNF3W4YV_tfj_RYPe2HDCKTIOY4tV_dks5uZYcKgaJpZM4WgD49 .

-- oxxxxxxx{;;;;;;;;;;;;;;;;;;;;;;;;;;;;;>