search

BaldMansMojo / check_vmware_esx

chech_vmware_esx Fork of check_vmware_api.pl
GNU General Public License v2.0
124 stars 67 forks source link

Output of openvmtools #194

Closed curropar closed 2 years ago

curropar commented 2 years ago

Hi,

I was trying to find a way of filtering the VMs with " Installed,running,but not managed by VMWare. " from the output of -S runtime -s tools, when I found there's an undocumented option, --open_vm_tools_ok, that almost does that.

The option does not increment the counter for not ok VMs, but still gets the VM in the output. In my opinion, given that the output throws just VMs with problems and we called the script with --open_vm_tools_ok, those VMs should not be in the output.

To change the behavior, it would only require to move the referenced line of code just 6 lines, below the next else: https://github.com/BaldMansMojo/check_vmware_esx/blob/37d222ec9a2b662eeb41fe1ae1cce49d0db6dac1/modules/dc_runtime_info.pm#L511

Thanks for checking it out!

curropar commented 2 years ago

Issue duplicated: https://github.com/BaldMansMojo/check_vmware_esx/issues/168