BaldMansMojo / check_vmware_esx

chech_vmware_esx Fork of check_vmware_api.pl
GNU General Public License v2.0
124 stars 67 forks source link

Soap API flag responds improperly or documentation is incorrect. #71

Closed morgajel closed 9 years ago

morgajel commented 9 years ago

SOAP API:

-S, --select=soap simple check to verify a successfull connection to VMWare SOAP API.

This implies -S and --select=soap are interchangeable. However, when you try to use -S, you get the following error:

[user@hostname:/opt/check_vmware_esx]# ./check_vmware_esx.pl -D 192.168.2.3 -f /etc/icinga2/.vmware-credentials -S
Option S requires an argument
Use of uninitialized value $select in lc at ./check_vmware_esx.pl line 1809.
Unknown datacenter select
<contents of help spews out>

note that --select=soap does work as intended.

[user@hostname:/opt/check_vmware_esx]# ./check_vmware_esx.pl -D 192.168.2.3 -f /etc/icinga2/.vmware-credentials --select=soap
OK: Successfully connected to the VMWare SOAP API.
BaldMansMojo commented 9 years ago

Option S requires an argument!! That means (like in most other unix progams -S soap. As you can see for the whole plugin -S means select and -s means subselect.. No one else hat problems with the syntax before. But for the next release I will rework the help.

morgajel commented 9 years ago

gah, nevermind, I wasn't paying attention. please ignore me.