Console.re support - Githubissues

Baldhor / Homey-ESPhome-Enhanced

This is an Homey app which adds support for ESPHome devices. ESPHome is a system to control your ESP8266/ESP32 by simple yet powerful configuration files and control them remotely through Home Automation systems. More information on their homepage: https://www.esphome.io/

GNU General Public License v3.0

4 stars 3 forks source link

Console.re support #3

Closed Baldhor closed 10 months ago

Baldhor commented 10 months ago

Is your feature request related to a problem? Please describe. Currently, it is difficult to investigate user issues

Describe the solution you'd like I want all logs (from the app, driver and devices, but also the pairing pages) to be sent on a console.re channel

Describe alternatives you've considered none

Additional context First integration of the console.re client shown an increase of 40 Mo in the application size, which is not acceptable. Considering a direct socket.io integration to avoid all the dependancies of the "standard" client

Baldhor commented 10 months ago

see branch consolere

Baldhor commented 10 months ago

Merged and published => 0.3.3 Strange enough, it was instantly certified and so it live!

Baldhor commented 10 months ago

Missing functionnalities:

Also publish console logs to consoleRe (currently only the App logs are published)
Publish unhandled exception to consoleRe
Optionnal: Generate unique channel automatically
Optionnal: Publish unhandled rejected promise to consoleRe

Issues:

On app startup, the connection to consoleRe is slow (like 10 seconds), and on reconnect (forcing disabled/enabled from settings), it's instant
The PromiseBuffer should consider if the connection is established, currently all the startup logs are lost. And so the buffer should have a limited size (100 ?)

Baldhor commented 10 months ago

wiki page: https://github.com/Baldhor/Homey-ESPhome-Enhanced/wiki/ConsoleRe-support

Baldhor commented 10 months ago

Fixed a callstack overflow in 0.3.4

Baldhor commented 10 months ago

Both issues are solved:

On app startup, the connection to consoleRe is slow (like 10 seconds), and on reconnect (forcing disabled/enabled from settings), it's instant
The PromiseBuffer should consider if the connection is established, currently all the startup logs are lost. And so the buffer should have a limited size (100 ?)

Missing functionnalities are not of high priority but still need some work:

Also publish console logs to consoleRe (currently only the App logs are published)
Publish unhandled exception to consoleRe
Optionnal: Generate unique channel automatically
Optionnal: Publish unhandled rejected promise to consoleRe

Baldhor commented 10 months ago

Closing, addition of functionnalities are not necessary at the moment