Baldinof / roadrunner-bundle

A RoadRunner worker integrated in your Symfony app
MIT License
266 stars 47 forks source link

Remove deprecation messages for ODM integration and worker command #105

Closed Khazhinov closed 1 year ago

Khazhinov commented 1 year ago

Hello! Thanks for the great library! Symfony started complaining about outdated code, so here's a quick fix for that.

Please note that this fix requires the minimum PHP version to be increased to 8.0

I hope this problem will be fixed in the next major release.

Baldinof commented 1 year ago

@Khazhinov Can add ignores in the phpstan config for the Attribute class Symfony\Component\Console\Attribute\AsCommand does not exists. errors in CI?

Khazhinov commented 1 year ago

@Khazhinov Can add ignores in the phpstan config for the Attribute class Symfony\Component\Console\Attribute\AsCommand does not exists. errors in CI?

Okay, but: This error does not exist if using Symfony 6.0+

Baldinof commented 1 year ago

Symfony 4.4 is still maintained until november 2023 so I'd like to keep supporting it.

It should not trigger errors at runtime, even if the class does not exists.

Khazhinov commented 1 year ago

This is a great But you can just keep different package versions for different versions of Symfony This is, of course, IMHO

Thanks!

Khazhinov commented 1 year ago

When can we expect a new version with this pr?

Baldinof commented 1 year ago

👋 I just released version 3.0.0 which should not trigger deprecations with ODM now.